This repository has been archived by the owner on Aug 25, 2022. It is now read-only.
Rdf::hasGraph breaks if the entity is new #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idimopoulos
changed the title
|
We have no test coverage any more, Travis has been disabled for the |
pfrenssen
approved these changes
Apr 28, 2020
|
I ran the test suite locally and all are passing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
\Drupal\rdf_entity\Entity\Rdf::hasGraphchecks if the entity has a copy of itself into the specified graph.However, the method fails if the entity is new and this method is called due to the lack of ID.
Even if there was an ID (like manually set before the entity is saved) it wouldn't make sense to run a query in the database since we know that it is new.
I am providing a test for the method itself that proves the issue and a fix.