Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lighter-video-files rule #61

Merged
merged 12 commits into from Nov 15, 2022
Merged

Add lighter-video-files rule #61

merged 12 commits into from Nov 15, 2022

Conversation

martinabab
Copy link
Collaborator

Pull Request purpose

[ ] Documentation update
[ ] Bug fix
[X] New rule
[ ] Updates an existing rule
[ ] Add something to the core
[ ] Other, please explain:

Checklist

[ ] Update CHANGELOG.md
[ ] Update task status in release plan (README)
[ ] Docs added (/docs/rules/<rule_name>)
[ ] Docs ready to be added to website (ec0lint.com)

Overview of changes

Would you like to add anything more?

@martinabab martinabab mentioned this pull request Nov 13, 2022
1 task
Copy link
Collaborator

@malwinq malwinq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general looks good to me, just the log message change

lib/rules/lighter-video-files.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@nemmip nemmip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Great job!

@martinabab martinabab merged commit a2f310e into ec0lint:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants