md_is_link_title: Stop on ')' lin ()-style title.

Fixes mity#60.
ec1oud · Apr 17, 2019 · 2038608 · 2038608
1 parent 4bfaaed
commit 2038608
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -8,7 +8,8 @@ Fixes:
 
  * Fixed some quadratic behaviors:
    [#58](https://github.com/mity/md4c/issues/58),
-   [#59](https://github.com/mity/md4c/issues/59)
+   [#59](https://github.com/mity/md4c/issues/59),
+   [#60](https://github.com/mity/md4c/issues/60)
 
  * [#61](https://github.com/mity/md4c/issues/59): Flag `MD_FLAG_NOHTMLSPANS`
    erroneously affected also recognition of CommonMark autolinks.

diff --git a/md4c/md4c.c b/md4c/md4c.c
@@ -2058,6 +2058,9 @@ md_is_link_title(MD_CTX* ctx, const MD_LINE* lines, int n_lines, OFF beg,
                 *p_end = off+1;
                 *p_end_line_index = line_index;
                 return TRUE;
+            } else if(closer_char == _T(')')  &&  CH(off) == _T('(')) {
+                /* ()-style title cannot contain (unescaped '(')) */
+                return FALSE;
             }
 
             off++;

diff --git a/test/pathological_tests.py b/test/pathological_tests.py
@@ -74,7 +74,10 @@
                   re.compile("(&lt;&gt;){50000}")),
     "many backticks and escapes":
                  (("\\``" * 50000),
-                  re.compile("(``){50000}"))
+                  re.compile("(``){50000}")),
+    "many broken link titles":
+                 (("[ (](" * 50000),
+                  re.compile("(\[ \(\]\(){50000}"))
     }
 
 whitespace_re = re.compile('/s+/')