Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added document about tradeoffs between key import and portability #331

Closed

Conversation

michaelkernaghan
Copy link
Contributor

closes #114

Discuss the trade-offs between key import and key portability

@cloudflare-pages
Copy link

cloudflare-pages bot commented Mar 17, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: ebad93d
Status: ✅  Deploy successful!
Preview URL: https://7ece6a33.signatory.pages.dev
Branch Preview URL: https://mk-114-doc-about-key-import.signatory.pages.dev

View logs

@michaelkernaghan michaelkernaghan added the docs Documentation issue label Mar 17, 2023
Copy link
Contributor

@AbineshECAD AbineshECAD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty doc file? Am I missing something?

Copy link
Contributor

@stephengaudet stephengaudet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't make PR for empty files

@michaelkernaghan
Copy link
Contributor Author

the PR is not supposed to be empty; the file was not uploaded. Fixed.

docs/key_portability.md Outdated Show resolved Hide resolved
@michaelkernaghan michaelkernaghan marked this pull request as ready for review March 27, 2023 14:07
docs/key_portability.md Show resolved Hide resolved
docs/key_portability.md Show resolved Hide resolved
docs/key_portability.md Show resolved Hide resolved
Copy link
Contributor

@AbineshECAD AbineshECAD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do users browse to this doc?

@michaelkernaghan
Copy link
Contributor Author

How do users browse to this doc?

i forgot the sidebar entry. I have added it and pushed the change. thanks.

@michaelkernaghan
Copy link
Contributor Author

not required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write doc about trade-offs around key portability and key import
3 participants