Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate duplicated Errors across packages #1993

Closed
roxaneletourneau opened this issue Oct 5, 2022 · 0 comments · Fixed by #2238, #2463 or #2470
Closed

Consolidate duplicated Errors across packages #1993

roxaneletourneau opened this issue Oct 5, 2022 · 0 comments · Fixed by #2238, #2463 or #2470
Assignees
@hui-an-yang
Labels
ga_release Work to be done so we can remove the beta dsignation
Projects
dev
Milestone
v16.2

Comments

@roxaneletourneau
Copy link
Collaborator

Follow up of #160 as described in https://hackmd.io/@tca0T8LZT3au8LG6hSX20g/r1zTRTlfj_

Task 2: Consolidate duplicated Errors across packages (InvalidViewParameterError, InvalidAddressError, InvalidBlockHashError, InvalidHexStringError, InvalidMessageError, ...)
@Innkst Innkst added this to To do in dev via automation Oct 13, 2022
@Innkst Innkst added this to the v14.1 milestone Oct 13, 2022
@Innkst Innkst added the ga_release Work to be done so we can remove the beta dsignation label Oct 13, 2022
@Innkst Innkst modified the milestones: v14.1, v15.1 Oct 27, 2022
@zainen zainen self-assigned this Dec 15, 2022
@zainen zainen moved this from To do to In progress in dev Dec 15, 2022
@zainen zainen moved this from In progress to To do in dev Dec 15, 2022
@zainen zainen moved this from To do to In progress in dev Dec 15, 2022
@zainen zainen mentioned this issue Dec 20, 2022
Merged
@zainen zainen moved this from In progress to Review in progress in dev Dec 20, 2022
dev automation moved this from Review in progress to Done Jan 6, 2023
hui-an-yang added a commit that referenced this issue Jan 6, 2023
@hui-an-yang
refactor: moving taquito-utils errors used across packages into taqui…
6fa217a 
…to-core

re #1993
zainen pushed a commit that referenced this issue Jan 7, 2023
@hui-an-yang
refactor: moving taquito-utils errors used across packages into taqui…
6131cfe 
…to-core

re #1993
hui-an-yang added a commit that referenced this issue Jan 9, 2023
@hui-an-yang
fix: merge conflicts
a673831 
re #1993
hui-an-yang added a commit that referenced this issue Jan 9, 2023
@hui-an-yang
fix: merge conlicts update
b8d80ab 
re #1993
zainen pushed a commit that referenced this issue Jan 9, 2023
@hui-an-yang
refactor: moving taquito-utils errors used across packages into taqui…
8c58b6b 
…to-core

re #1993
zainen pushed a commit that referenced this issue Jan 9, 2023
@hui-an-yang
refactor: moving taquito-utils errors used across packages into taqui…
55ad247 
…to-core

re #1993
zainen pushed a commit that referenced this issue Jan 10, 2023
@hui-an-yang
refactor: moving taquito-utils errors used across packages into taqui…
92a4411 
…to-core

re #1993
zainen pushed a commit that referenced this issue Jan 10, 2023
@hui-an-yang
refactor: moving taquito-utils errors used across packages into taqui…
51b3a8f 
…to-core

re #1993
zainen pushed a commit that referenced this issue Jan 10, 2023
@hui-an-yang
refactor: moving taquito-utils errors used across packages into taqui…
6d9e654 
…to-core

re #1993
zainen pushed a commit that referenced this issue Jan 10, 2023
@hui-an-yang
refactor: moving taquito-utils errors used across packages into taqui…
9aa7132 
…to-core

re #1993
zainen pushed a commit that referenced this issue Jan 10, 2023
@hui-an-yang
refactor: moving taquito-utils errors used across packages into taqui…
8119a83 
…to-core

re #1993

refactor: moving taquito-utils errors used across packages into taquito-core

re #1993

refactor(taqutio utils / core): collect in core and extends higher level errors
zainen pushed a commit that referenced this issue Jan 11, 2023
@hui-an-yang
1993 move taquito utils errors to taquito core (#2278)
a9b0312 
* refactor: moving taquito-utils errors used across packages into taquito-core

re #1993

refactor: moving taquito-utils errors used across packages into taquito-core

re #1993

refactor(taqutio utils / core): collect in core and extends higher level errors

* fixes

* extend higher level derivationtype

* fix space { } and pr commments

* remove lock

* refactor: remove ;

Co-authored-by: Zainen Suzuki <zainensuzuki@Zainens-MacBook-Pro.local>
@hui-an-yang hui-an-yang reopened this Apr 24, 2023
dev automation moved this from Done to In progress Apr 24, 2023
@hui-an-yang hui-an-yang moved this from In progress to To do in dev Apr 24, 2023
hui-an-yang added a commit that referenced this issue Apr 25, 2023
@hui-an-yang
refactor: consolidated InvalidAddressError into @taquito/core
94f87fe 
re #1993
hui-an-yang added a commit that referenced this issue Apr 27, 2023
@hui-an-yang
refactor: imporved consolidation of InvalidAddressError
0a5173c 
re #1993
hui-an-yang added a commit that referenced this issue Apr 28, 2023
@hui-an-yang
refactor: imporved consolidation of InvalidAddressError 2
f2dacba 
re #1993
@hui-an-yang hui-an-yang moved this from To do to In progress in dev May 2, 2023
@Innkst Innkst assigned hui-an-yang and unassigned zainen May 2, 2023
@Innkst Innkst modified the milestones: v15.1, v16.2 May 2, 2023
hui-an-yang added a commit that referenced this issue May 3, 2023
@hui-an-yang
refactor: consolidated InvalidAddressError into @taquito/core
cacfc91 
re #1993
hui-an-yang added a commit that referenced this issue May 3, 2023
@hui-an-yang
refactor: consolidated InvalidBlockHashError into @taquito/core
96e3af7 
re #1993
hui-an-yang added a commit that referenced this issue May 3, 2023
@hui-an-yang
refactor: consolidated InvalidDerivationPathError into @taquito/core
250ccb4 
re #1993
hui-an-yang added a commit that referenced this issue May 3, 2023
@hui-an-yang
refactor: added InvalidDerivationPathError unit test in @taquito/core
5a8d3a6 
re #1993
hui-an-yang added a commit that referenced this issue May 3, 2023
@hui-an-yang
refactor: consolidated InvalidHexStringError in to @taquito/core and …
72cf4be 
…some style patches

re #1993
hui-an-yang added a commit that referenced this issue May 3, 2023
@hui-an-yang
refactor: consolidated InvalidMessageError into @taquito/core
2314b28 
re #1993
hui-an-yang added a commit that referenced this issue May 3, 2023
@hui-an-yang
refactor: consolidated InvalidViewParameterError into @taquito/core
990c115 
re #1993
hui-an-yang added a commit that referenced this issue May 3, 2023
@hui-an-yang
refactor: improve InvalidViewParameterError in @taquito/core
25b994e 
re #1993
@hui-an-yang hui-an-yang mentioned this issue May 3, 2023
Merged
9 tasks
@hui-an-yang hui-an-yang moved this from In progress to Review in progress in dev May 3, 2023
@hui-an-yang hui-an-yang linked a pull request May 3, 2023 that will close this issue
1993 consolidating duplicate errors #2463
Merged
9 tasks
hui-an-yang added a commit that referenced this issue May 5, 2023
@hui-an-yang
1993 consolidating duplicate errors (#2463)
282ec7d 
* refactor: consolidated InvalidAddressError into @taquito/core

re #1993

* refactor: consolidated InvalidBlockHashError into @taquito/core

re #1993

* refactor: consolidated InvalidDerivationPathError into @taquito/core

re #1993

* refactor: added InvalidDerivationPathError unit test in @taquito/core

re #1993

* refactor: consolidated InvalidHexStringError in to @taquito/core and some style patches

re #1993

* refactor: consolidated InvalidMessageError into @taquito/core

re #1993

* refactor: consolidated InvalidViewParameterError into @taquito/core

re #1993

* refactor: improve InvalidViewParameterError in @taquito/core

re #1993

* refactor: removed tailling params destination/source in InvalidAddressError
@hui-an-yang hui-an-yang moved this from Review in progress to Done in dev May 10, 2023
@hui-an-yang hui-an-yang mentioned this issue May 20, 2023
Merged
9 tasks
hui-an-yang added a commit that referenced this issue May 23, 2023
@hui-an-yang
Error improvement (#2470)
babcbaf 
* 1992 create high level error categories (#2452)

* build: created new package @taquito/core

re #1992

* feat: added high-level error categories with unit tests

re #1992

* build: new package-lock.json with @taquito-core for ci

* build: updated a file name and adjusted build order

* test: rename test file

* chore: bump @taquito/core version to 16.1.2

* 1993 consolidating duplicate errors (#2463)

* refactor: consolidated InvalidAddressError into @taquito/core

re #1993

* refactor: consolidated InvalidBlockHashError into @taquito/core

re #1993

* refactor: consolidated InvalidDerivationPathError into @taquito/core

re #1993

* refactor: added InvalidDerivationPathError unit test in @taquito/core

re #1993

* refactor: consolidated InvalidHexStringError in to @taquito/core and some style patches

re #1993

* refactor: consolidated InvalidMessageError into @taquito/core

re #1993

* refactor: consolidated InvalidViewParameterError into @taquito/core

re #1993

* refactor: improve InvalidViewParameterError in @taquito/core

re #1993

* refactor: removed tailling params destination/source in InvalidAddressError

* 1994 @taquito utils error improvement (#2475)

* refactor: consolidate InvalidKeyError inot @taquito/core and improve across packages

BREAKING CHANGE: Class SaplingToolkit function prepareUnshieldedTransaction used to throw
InvalidKeyError now throw a InvalidAddressError instead

re #1994

* refactor: consolidate InvalidPublicKey into @taquito/core and improve across packages

re #1994

* refactor: consolidate InvalidSignatureError into @taquito/core and improve across packages

re #1994

* refactor: minor update of the improved error classes

re #1994

* refactor: consolidate InvalidcontractAddressError into @taquito/core and improve across packages

re #1994

* refactor: consolidate InvalidChainIdError into @taquito/core and improve across packages

re #1994

* refactor: consolidate InvalidKeyHashError into @taquito/core and improve across packages

re #1994

* refactor: minor update for InvalidKeyHashError

re #1994

* refactor: consolidate InvalidOperationHashError into @taquito/core and improve across packages

re #1994

* refactor: consolidate InvalidOperationKindError into @taquito/core and improve across packages

re #1994

* refactor: consolidate DeprecationError into @taquito/core

re #1994

* refactor: consolidate ProhibitedActionError into @taquito/core

re #1994

* refactor: imporve InvalidProtocolHashError and ValueConversionError in @taquito/utils

re #1994

* refactor: added unit tests for error classes in @taquito/core

re #1994

* refactor: consolidate ValidationResult into @taquito/core

re #1994

* refactor: improve InvalidAddressError to show validation result in errorDetail

BREAKING CHANGE: 1. In @taquito/rpc when validateContractAddress used to throw InvalidAddressError
will now throw InvalidContractAddressError. 2. In @taquito/sapling prepareUnshieldedTransaction
function when validateDestinationImplicitAddress used to throw InvalidAddressError now throw
InvalidKeyHashError

re #1994

* refactor: improve InvalidAddressError message format to be concise

re #1994

* refactor: improve InvalidBlockHashError message format to be concise

re #1994

* refactor: improve InvalidDerivationPathError message format to be consistent

re #1994

* refactor: improve InvalidHexStringError message format

re #1994

* refactor: improve InvalidMessageError message format

re #1994

* refactor: improve InvalidViewParameterError message format

re #1994

* refactor: improve InvalidKeyError message format

re #1994

* refactor: improve teh rest of common error classes message format

* refactor: replaced deprecated substr with substring across packages

* refactor: moved validationResult back to @taquito/core

* refactor: addressed pr comments of wording and naming

* 1994 taquito local forging error improvement (#2486)

* refactor: update file name of error.ts to errors.ts for consistency

* refactor: improve InvalidOperationSchemaError

* refactor: improve OversizedEntryPointError

* refactor: improve InvalidBallotValueError

* refactor: improve DecodeBallotValueError

* refactor: imrpove UnexpectedMichelsonValueError

* refactor: improve OperationDecodingError

* refactor: imporve OperationEncodingError

* refactor: imrpove UnsupportedOperationError

* refactor: improve DecodePvmKindError

* refactor: improve InvalidSmartRollupAddressError

* refactor: improve InvalidSmartRollupCommitmentHashError and DecodePvmKindError

BREAKING CHANGE: 1. In @taquito/local-forging smartRollupAddressDecoder used to throw InvalidAddressError now throw invalidContractAddressErro 2. In @taquito/local-forging used to have class InvalidSmartRollupContractAddressError now is InvalidSmartRollupCommitmentHashError 3. In @taquito/local-forging function smartRollupContractAddressEncoder rename to smartRollupCommitmentHashEncoder

* 1994 taquito signer error improvement (#2490)

* refactor: imrpove InvalidMnemonicError

* refactor: improve InvalidBitSize and InvalidCurveError

* refactor: imporve InvalidSeedLengthError

* refactor: replace PrivateKeyError with InvalidKeyError from @taquito/core and improve InvalidKeyErro

BREAKING CHANGE: PrivateKeyError is replaced by common error InvalidKeyError from @taquito/core

* refactor: imrpove ToBeImplemented

* docs: added typedoc of InvalidSeedLengthError and ToBeImplemented

* refactor: imporve InvalidPassphraseError

* chore: updated pack-lock.json

* fix: fix overlooked merge conflicts

* chore: updated package-lock.json and keep bip39 v3.0.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hui-an-yang hui-an-yang

Labels
ga_release Work to be done so we can remove the beta dsignation
Projects
dev
  
Done
Milestone
v16.2
4 participants
@roxaneletourneau @zainen @Innkst @hui-an-yang