Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error in the Michelson-Encoder package #1995

Closed
roxaneletourneau opened this issue Oct 5, 2022 · 1 comment · Fixed by #2551
Closed

Improve error in the Michelson-Encoder package #1995

roxaneletourneau opened this issue Oct 5, 2022 · 1 comment · Fixed by #2551
Assignees
@ac10n
Labels
3 ga_release Work to be done so we can remove the beta dsignation
Projects
dev
Milestone
v17.1

Comments

@roxaneletourneau
Copy link
Collaborator

Follow up of #160 as described in https://hackmd.io/@tca0T8LZT3au8LG6hSX20g/r1zTRTlfj_

Task 4: @taquito/michelson-encoder package - We use the same error if an issue happens in the Encode and Execute methods. In some situations, it is hard to identify what went wrong. Make sure we clearly distinguish if it is a bad input from the user or an issue from the Execute method.
@Innkst Innkst added this to To do in dev via automation Oct 13, 2022
@Innkst Innkst added this to the v15 milestone Oct 13, 2022
@dsawali
Copy link
Collaborator

dsawali commented Nov 23, 2022

Hey team! Please add your planning poker estimate with Zenhub @zainen @roxaneletourneau @hui-an-yang @dsawali

@roxaneletourneau roxaneletourneau modified the milestones: v15, v15.1 Dec 7, 2022
@Innkst Innkst added the ga_release Work to be done so we can remove the beta dsignation label Dec 7, 2022
@Innkst Innkst modified the milestones: v15.1, v16.1 Dec 29, 2022
@Innkst Innkst modified the milestones: v16.1, v16.2 Mar 11, 2023
@Innkst Innkst modified the milestones: v16.2, v17 May 17, 2023
@Innkst Innkst added the 3 label May 24, 2023
@ac10n ac10n moved this from To do to In progress in dev Jun 5, 2023
@ac10n ac10n self-assigned this Jun 5, 2023
@ac10n ac10n mentioned this issue Jun 21, 2023
Closed
9 tasks
@Innkst Innkst modified the milestones: v17, v17.1 Jun 21, 2023
ac10n added a commit that referenced this issue Jul 4, 2023
@ac10n
chore(michelson encoder): improved Errors in the Michelson Encoder Pa…
3b17d7c 
…ckage

Refactored errors in the Michelson Encoder package to have better messages and be more informative
to the user

closes #1995
@ac10n ac10n mentioned this issue Jul 4, 2023
Merged
9 tasks
@ac10n ac10n moved this from In progress to Review in progress in dev Jul 5, 2023
ac10n added a commit that referenced this issue Jul 11, 2023
@ac10n
chore(michelson encoder): improved Errors in the Michelson Encoder Pa…
da819a0 
…ckage (#2551)

* chore(michelson encoder): improved Errors in the Michelson Encoder Package

Refactored errors in the Michelson Encoder package to have better messages and be more informative
to the user

closes #1995

* chore: fix build error

* chore: fix failing tests

* chore: fix remaining errors

* chore: update message assignment for consistency

* chore: apply suggestions from PR review
dev automation moved this from Review in progress to Done Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ac10n ac10n

Labels
3 ga_release Work to be done so we can remove the beta dsignation
Projects
dev
  
Done
Milestone
v17.1
4 participants
@ac10n @dsawali @roxaneletourneau @Innkst