Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Oxford2] Update local forger to include 'whitelist' property for smart rollup originate #2776

Closed
dsawali opened this issue Dec 22, 2023 · 0 comments · Fixed by #2781
Closed

[Oxford2] Update local forger to include 'whitelist' property for smart rollup originate #2776

dsawali opened this issue Dec 22, 2023 · 0 comments · Fixed by #2781
Assignees
@hui-an-yang
Labels
oxford2
Projects
dev
Milestone
v19

Comments

@dsawali
Copy link
Collaborator

dsawali commented Dec 22, 2023

Oxford2 introduced changes to Smart Rollups where you can now make use of private rollups.

The whitelist property is introduced as an optional property now in smart_rollup_originate

Investigate and implement the changes in local forger to reflect the changes.

The smart_rollup_originate operation now also takes an optional whitelist of public key hashes. This whitelist cannot be used yet (the sc_rollup.private_enable flag has to be set to true). (MR !9401)

Relevant docs:
@dsawali dsawali added this to the v19 milestone Dec 22, 2023
@dsawali dsawali added this to To do in dev via automation Dec 22, 2023
@dsawali dsawali changed the title [Oxford2] Update local forger schema for smart rollup originate to include 'whitelist' property [Oxford2] Update local forger to include 'whitelist' property for smart rollup originate Dec 22, 2023
@dsawali dsawali mentioned this issue Dec 22, 2023
Merged
9 tasks
hui-an-yang added a commit that referenced this issue Jan 2, 2024
@hui-an-yang
feat: supported smartRollupOriginate with new pvmKind and property wh…
d8c1942 
…itelist in localForger

re #2776
@hui-an-yang hui-an-yang linked a pull request Jan 2, 2024 that will close this issue
2776 smart rollup origination with whitelist #2781
Merged
9 tasks
@hui-an-yang hui-an-yang self-assigned this Jan 2, 2024
@hui-an-yang hui-an-yang mentioned this issue Jan 2, 2024
Merged
9 tasks
@hui-an-yang hui-an-yang moved this from To do to Review in progress in dev Jan 2, 2024
hui-an-yang added a commit that referenced this issue Jan 5, 2024
@hui-an-yang @dsawali
2776 smart rollup origination with whitelist (#2781)
cd1f805 
* removed references to originationProof

* trigger checks

* trigger checks

* test commit

* adjusted more tests

* removed remaining origination proof artifacts

* updated smart rollup docs

* adjusted estimates

* feat: supported smartRollupOriginate with new pvmKind and property whitelist in localForger

re #2776

* refactor: addressed comments of naming for clarity

* test: updated contract-estimation-tests-spec.ts assertions

---------

Co-authored-by: Davis Sawali <davis.sawali@ecadlabs.com>
@dsawali dsawali moved this from Review in progress to Done in dev Jan 8, 2024
dsawali added a commit that referenced this issue Jan 29, 2024
@hui-an-yang @dsawali
Oxford2 (#2771)
0470023 
* 2762 oxford2 branch configuration (#2764)

* ci: initial configuration of oxford2 branch

re #2762

* docs: replaced mumbai ref with oxford2 of rpc_nodes and wallet_api on webstie

* docs: add oxfordnet to wallet_api in next version of website

* ci: update ci script origiante-known-contracts command

* remove tx rollups references in taquito (#2770)

* remove tx rollups references in taquito

* updated unit test

* removed remaining tx rollup references

* 2596 oxford2 update rpc types (#2772)

* feat: updated rpc endpoint changes for oxford2

re #2596

* fix: fix auto-merge mistake by removing tx ref

* test: fix integration test of pendingOperations

* test: removed unnecessory import

* refactor: imporved ux of rpc endpoint of blockOption version

* 2597 remove proof (#2774)

* removed references to originationProof

* trigger checks

* trigger checks

* test commit

* adjusted more tests

* removed remaining origination proof artifacts

* updated smart rollup docs

* adjusted estimates

* 2776 smart rollup origination with whitelist (#2781)

* removed references to originationProof

* trigger checks

* trigger checks

* test commit

* adjusted more tests

* removed remaining origination proof artifacts

* updated smart rollup docs

* adjusted estimates

* feat: supported smartRollupOriginate with new pvmKind and property whitelist in localForger

re #2776

* refactor: addressed comments of naming for clarity

* test: updated contract-estimation-tests-spec.ts assertions

---------

Co-authored-by: Davis Sawali <davis.sawali@ecadlabs.com>

* 2599 oxford2 supports attestation (#2775)

* feat: supports attesation along side endorsement

re #2599

* feat: the rest of files of supports attesation along side endorsement

* test: fix protocol logic in integration-tests/rpc-nodes.spec.ts

* test: addressed pr comments of naming

* test: updated contract-estimation-tests.spec.ts assertions

* 2653 oxford2 reintroduce timelock (#2780)

* test: added local-forging timelock test case with chest, chest_key and OPEN_CHEST

re #2653

* test: added integration test originating with chest&chest_key in storage (chest_key unfinished)

* test: updated chestKeyValue in integration-tests

re #2653

* test: removed unneeded comment

* test: address comment to reduce timeout risk

* Oxford2 cleanup (#2791)

* docs: updated to oxford references whereever fits

* feat: updated rpc types and doc changes

* ci: removed nairobi and replace mondaynet with weeklynet

* fix: replaced modanynet as weeklynet

* ci: comment out oxfordbox tests until oxford2 flextesa image releases

* docs: address typedoc comments

* removed newline

* chore(releng) bump version to 19.0.0-beta-RC.0

* chore: satisfy lerna

* chore(releng) bump version to 19.0.0

---------

Co-authored-by: Davis Sawali <davis.sawali@ecadlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hui-an-yang hui-an-yang

Labels
oxford2
Projects
dev
  
Done
Milestone
v19
Development

Successfully merging a pull request may close this issue.

2776 smart rollup origination with whitelist ecadlabs/taquito
2 participants
@dsawali @hui-an-yang