Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed sapling deps and live code examples #2810

Merged
merged 1 commit into from Feb 1, 2024
Merged

Conversation

dsawali
Copy link
Collaborator

@dsawali dsawali commented Jan 31, 2024

Live code examples for Sapling were importing a file from its dependencies that has a 69MB file. This prevents the website from being deployed to Cloudflare due to the file size limit. It also potentially reduces performance of the website.

This PR disables live code examples for Sapling. The static code examples will still be kept.

Thank you for your contribution to Taquito.

Before submitting this PR, please make sure:

  • Your code builds cleanly without any errors or warnings
  • You have run the linter against the changes
  • You have added unit tests (if relevant/appropriate)
  • You have added integration tests (if relevant/appropriate)
  • All public methods or types have TypeDoc coverage with a complete description, and ideally an @example
  • You have added or updated corresponding documentation
  • If relevant, you have written a first draft summary describing the change for inclusion in Release Notes.

In this PR, please also make sure:

  • You have linked this PR to the issue by putting closes #TICKETNUMBER in the description box (when applicable)
  • You have added a concise description on your changes

Release Note Draft Snippet

If relevant, please write a summary of your change that will be suitable for
inclusion in the Release Notes for the next Taquito release.

Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for taquito-test-dapp ready!

Name Link
🔨 Latest commit 666c32d
🔍 Latest deploy log https://app.netlify.com/sites/taquito-test-dapp/deploys/65bac07e3d3f930008db61f2
😎 Deploy Preview https://deploy-preview-2810--taquito-test-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 666c32d
Status: ✅  Deploy successful!
Preview URL: https://12b3dc9b.taquito.pages.dev
Branch Preview URL: https://fix-large-bundle-size.taquito.pages.dev

View logs

Copy link

New packages have been deployed to the preview repository at https://npm.preview.tezostaquito.io/.

Published packages:

npm i @taquito/taquito@19.0.0-c481a62-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/tzip12@19.0.0-c481a62-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/utils@19.0.0-c481a62-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/signer@19.0.0-c481a62-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/remote-signer@19.0.0-c481a62-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/rpc@19.0.0-c481a62-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/http-utils@19.0.0-c481a62-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/michel-codec@19.0.0-c481a62-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/beacon-wallet@19.0.0-c481a62-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/sapling@19.0.0-c481a62-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/contracts-library@19.0.0-c481a62-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/local-forging@19.0.0-c481a62-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/tzip16@19.0.0-c481a62-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/michelson-encoder@19.0.0-c481a62-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/ledger-signer@19.0.0-c481a62-- --registry https://npm.preview.tezostaquito.io/
npm i @taquito/core@19.0.0-c481a62-- --registry https://npm.preview.tezostaquito.io/

Copy link

A new deploy preview is available on Netlify at https://c481a62--tezostaquito.netlify.app

@dsawali dsawali marked this pull request as ready for review February 1, 2024 18:56
@dsawali dsawali merged commit 1bd44de into master Feb 1, 2024
12 checks passed
@dsawali dsawali deleted the fix-large-bundle-size branch February 1, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant