Skip to content

Commit

Permalink
Document trusted oauth providers
Browse files Browse the repository at this point in the history
  • Loading branch information
simfeld committed Mar 26, 2024
1 parent 38deb1c commit 891267c
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions api/src/Entity/Profile.php
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,14 @@ class Profile extends BaseEntity {
#[ORM\Column(type: 'string', length: 255, nullable: true)]
public ?string $untrustedEmailKeyHash = null;

// ========================= start trusted Oauth provider ids =========================
// Note: as of https://github.com/ecamp/ecamp3/pull/4779 we are assuming that email
// addresses received from Oauth providers are trusted in the sense that email ownership has
// previously been verified by the corresponding service. When adding more providers, either
// - validate this assumption for the new provider, or
// - remove the logic setting the user state to active for existing non-activated user profiles
// in the new authenticator implementation (api/src/Security/OAuth/*Authenticator.php)

/**
* Google id of the user.
*/
Expand Down Expand Up @@ -119,6 +127,8 @@ class Profile extends BaseEntity {
#[ORM\Column(type: 'string', length: 255, nullable: true)]
public ?string $jubladbId = null;

// ========================= end trusted Oauth provider ids =========================

/**
* The user's (optional) first name.
*/
Expand Down

0 comments on commit 891267c

Please sign in to comment.