Adjust and extend tests

ecamp · Mar 27, 2024 · e644613 · e644613
1 parent 81a5694
commit e644613
Show file tree

Hide file tree

Showing 3 changed files with 124 additions and 8 deletions.
diff --git a/api/tests/Api/Categories/CreateCategoryTest.php b/api/tests/Api/Categories/CreateCategoryTest.php
@@ -99,10 +99,10 @@ public function testCreateCategoryCreatesNewColumnLayoutAsRootContentNode() {
 
         $this->assertResponseStatusCodeSame(201);
         $newestColumnLayout = $this->getEntityManager()->getRepository(ContentNode::class)
-            ->findBy(['contentType' => static::$fixtures['contentTypeColumnLayout']], ['createTime' => 'DESC'])[0]
+            ->findBy(['contentType' => static::$fixtures['contentTypeColumnLayout'], 'instanceName' => null], ['createTime' => 'DESC'], 1)[0]
         ;
         $this->assertJsonContains(['_links' => [
-            'rootContentNode' => ['href' => '/content_node/column_layouts/'.$newestColumnLayout->getId()],
+            'rootContentNode' => ['href' => $this->getIriFor($newestColumnLayout)],
         ]]);
     }
 
@@ -456,6 +456,102 @@ public function testCreateCategoryValidatesInvalidNumberingStyle() {
         ]);
     }
 
+    public function testCreateCategoryFromCopySourceValidatesAccess() {
+        static::createClientWithCredentials(['email' => static::$fixtures['user8memberOnlyInCamp2']->getEmail()])->request(
+            'POST',
+            '/categories',
+            ['json' => $this->getExampleWritePayload(
+                [
+                    'camp' => $this->getIriFor('camp2'),
+                    'copyCategorySource' => $this->getIriFor('category1'),
+                ]
+            )]
+        );
+
+        // No Access on category1 -> BadRequest
+        $this->assertResponseStatusCodeSame(400);
+    }
+
+    public function testCreateCategoryFromCopySourceWithinSameCamp() {
+        static::createClientWithCredentials()->request(
+            'POST',
+            '/categories',
+            ['json' => $this->getExampleWritePayload(
+                [
+                    'camp' => $this->getIriFor('camp1'),
+                    'copyCategorySource' => $this->getIriFor('category1'),
+                ],
+            )]
+        );
+
+        // Category created
+        $this->assertResponseStatusCodeSame(201);
+    }
+
+    public function testCreateCategoryFromCopySourceAcrossCamp() {
+        static::createClientWithCredentials()->request(
+            'POST',
+            '/categories',
+            ['json' => $this->getExampleWritePayload(
+                [
+                    'camp' => $this->getIriFor('camp2'),
+                    'copyCategorySource' => $this->getIriFor('category1'),
+                ],
+            )]
+        );
+
+        // Category created
+        $this->assertResponseStatusCodeSame(201);
+    }
+
+    public function testCreateCategoryFromCopySourceActivityValidatesAccess() {
+        static::createClientWithCredentials(['email' => static::$fixtures['user8memberOnlyInCamp2']->getEmail()])->request(
+            'POST',
+            '/categories',
+            ['json' => $this->getExampleWritePayload(
+                [
+                    'camp' => $this->getIriFor('camp2'),
+                    'copyCategorySource' => $this->getIriFor('activity1'),
+                ]
+            )]
+        );
+
+        // No Access on activity1 -> BadRequest
+        $this->assertResponseStatusCodeSame(400);
+    }
+
+    public function testCreateCategoryFromCopySourceActivityWithinSameCamp() {
+        static::createClientWithCredentials()->request(
+            'POST',
+            '/categories',
+            ['json' => $this->getExampleWritePayload(
+                [
+                    'camp' => $this->getIriFor('camp1'),
+                    'copyCategorySource' => $this->getIriFor('activity1'),
+                ],
+            )]
+        );
+
+        // Category created
+        $this->assertResponseStatusCodeSame(201);
+    }
+
+    public function testCreateCategoryFromCopySourceActivityAcrossCamp() {
+        static::createClientWithCredentials()->request(
+            'POST',
+            '/categories',
+            ['json' => $this->getExampleWritePayload(
+                [
+                    'camp' => $this->getIriFor('camp2'),
+                    'copyCategorySource' => $this->getIriFor('activity1'),
+                ],
+            )]
+        );
+
+        // Category created
+        $this->assertResponseStatusCodeSame(201);
+    }
+
     /**
      * @throws RedirectionExceptionInterface
      * @throws DecodingExceptionInterface
@@ -488,6 +584,7 @@ public function getExampleWritePayload($attributes = [], $except = []) {
             Category::class,
             Post::class,
             array_merge([
+                'copyCategorySource' => null,
                 'camp' => $this->getIriFor('camp1'),
                 'preferredContentTypes' => [$this->getIriFor('contentTypeSafetyConcept')],
             ], $attributes),

diff --git a/...i/SnapshotTests/__snapshots__/ResponseSnapshotTest__testOpenApiSpecMatchesSnapshot__1.yml b/...i/SnapshotTests/__snapshots__/ResponseSnapshotTest__testOpenApiSpecMatchesSnapshot__1.yml
@@ -362,7 +362,7 @@ components:
           format: iri-reference
           type: string
         copyActivitySource:
-          description: 'Copy Contents from this Source-Activity.'
+          description: 'Copy contents from this source activity.'
           example: /activities/1a2b3c4d
           format: iri-reference
           type:
@@ -762,7 +762,7 @@ components:
           format: iri-reference
           type: string
         copyActivitySource:
-          description: 'Copy Contents from this Source-Activity.'
+          description: 'Copy contents from this source activity.'
           example: /activities/1a2b3c4d
           format: iri-reference
           type:
@@ -1201,7 +1201,7 @@ components:
           format: iri-reference
           type: string
         copyActivitySource:
-          description: 'Copy Contents from this Source-Activity.'
+          description: 'Copy contents from this source activity.'
           example: /activities/1a2b3c4d
           format: iri-reference
           type:
@@ -5998,6 +5998,13 @@ components:
           maxLength: 8
           pattern: '^(#[0-9a-zA-Z]{6})$'
           type: string
+        copyCategorySource:
+          description: 'Copy contents from this source category or activity.'
+          example: /categories/1a2b3c4d
+          format: iri-reference
+          type:
+            - 'null'
+            - string
         name:
           description: 'The full name of the category.'
           example: Lagersport
@@ -6383,6 +6390,13 @@ components:
           maxLength: 8
           pattern: '^(#[0-9a-zA-Z]{6})$'
           type: string
+        copyCategorySource:
+          description: 'Copy contents from this source category or activity.'
+          example: /categories/1a2b3c4d
+          format: iri-reference
+          type:
+            - 'null'
+            - string
         name:
           description: 'The full name of the category.'
           example: Lagersport
@@ -6755,6 +6769,13 @@ components:
           maxLength: 8
           pattern: '^(#[0-9a-zA-Z]{6})$'
           type: string
+        copyCategorySource:
+          description: 'Copy contents from this source category or activity.'
+          example: /categories/1a2b3c4d
+          format: iri-reference
+          type:
+            - 'null'
+            - string
         name:
           description: 'The full name of the category.'
           example: Lagersport

diff --git a/frontend/src/components/campAdmin/DialogCategoryCreate.vue b/frontend/src/components/campAdmin/DialogCategoryCreate.vue
@@ -19,9 +19,7 @@
         <template #activator="{ on }">
           <v-btn v-show="clipboardPermission === 'prompt'" v-on="on">
             <v-icon left>mdi-information-outline</v-icon>
-            {{
-              $tc('components.campAdmin.dialogCategoryCreate.copyPasteCategory')
-            }}
+            {{ $tc('components.campAdmin.dialogCategoryCreate.copyPasteCategory') }}
           </v-btn>
         </template>
       </CopyCategoryInfoDialog>