Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing profile names is not reactive #2994

Closed
usu opened this issue Sep 25, 2022 · 3 comments · Fixed by #3404
Closed

Changing profile names is not reactive #2994

usu opened this issue Sep 25, 2022 · 3 comments · Fixed by #3404

Comments

@usu
Copy link
Member

usu commented Sep 25, 2022

Changing nickname, surname or firstname in profile is not reactive, because user.displayName is used to display the name of the user in the frontend.

Potential solution:

  • Reload user entity after changing any of these properties in profile
  • Or: embedd user entity in response from API

image

@carlobeltrame
Copy link
Member

Another solution would be, if we ever get around to implementing ecamp/hal-json-vuex#2. Then we could automatically define a getter user.displayName in the frontend which assembles the displayName from the linked profile data.

@usu
Copy link
Member Author

usu commented Oct 1, 2022

Yep, that would be a nice application of this feature.

If we're concerned about the authenticated user only, then another option would be to add a vuex getter to the new vuex module introduced here: https://github.com/ecamp/ecamp3/pull/2993/files#diff-40fa57b3059ed8e2b66c007c75f7c73bfb5426ab13b62a029adb31cc8ee91d49

@carlobeltrame
Copy link
Member

Immediate problem was fixed in #3403. Further refactoring is being done in #3404.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants