Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continuous-integration.yml: use COVERALLS_TOKEN to send coveralls rep… #3433

Closed

Conversation

BacLuc
Copy link
Contributor

@BacLuc BacLuc commented May 1, 2023

…orts

This is how it is documented in https://github.com/nickmerwin/node-coveralls#usage I dont know why this worked before.

For php we use the github action, and there we only need this special token for sending local coverage info to coveralls: https://github.com/marketplace/actions/coveralls-github-action For the github action, the GITHUB_ACTION token suffices.

…orts

This is how it is documented in https://github.com/nickmerwin/node-coveralls#usage
I dont know why this worked before.

For php we use the github action, and there we only need this special token for sending local coverage info to coveralls:
https://github.com/marketplace/actions/coveralls-github-action
For the github action, the GITHUB_ACTION token suffices.
@BacLuc BacLuc marked this pull request as ready for review May 1, 2023 08:53
@BacLuc
Copy link
Contributor Author

BacLuc commented May 1, 2023

What is a little scary is that npx coveralls worked on my fork without a coveralls token: https://github.com/BacLuc/ecamp3/actions/runs/4849643951/jobs/8641827192
...?

@BacLuc BacLuc marked this pull request as draft May 1, 2023 17:24
@BacLuc
Copy link
Contributor Author

BacLuc commented May 1, 2023

coveralls seems to work again...?

@usu
Copy link
Member

usu commented May 1, 2023

Check this comment: lemurheavy/coveralls-public#1607 (comment)

It seems there is some special logic on coveralls side. When COVERALLS_SERVICE_NAME equals github, coveralls would accept GITHUB_TOKEN. The official documentation suggests however, that in this case, the github token should be passed via environment variable GITHUB_TOKEN. So the behaviour that the github token is accepted in COVERALLS_REPO_TOKEN seems not a officially documented method.

I think the safest way is to use a different COVERALLS_SERVICE_NAME for frontend and print.

@BacLuc
Copy link
Contributor Author

BacLuc commented Jul 15, 2023

Will close that for now

@BacLuc BacLuc closed this Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants