UnitTest testSqlQueryCount for GetEntity and GetCollection

api/tests/Api/Activities/ListActivitiesTest.php

@@ -88,4 +88,12 @@ public function testListActivitiesFilteredByCampPrototypeIsAllowedForUnrelatedUs
             ['href' => $this->getIriFor('activity1campPrototype')],
         ], $response->toArray()['_links']['items']);
     }
+
+    public function testSqlQueryCount() {
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/activities');
+
+        $this->assertSqlQueryCount($client, 19);
+    }
 }

api/tests/Api/Activities/ReadActivityTest.php

@@ -132,4 +132,15 @@ public function testGetSingleActivityFromCampPrototypeIsAllowedForUnrelatedUser(
             ],
         ]);
     }
+
+    public function testSqlQueryCount() {
+        /** @var Activity $activity */
+        $activity = static::$fixtures['activity1'];
+
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/activities/'.$activity->getId());
+
+        $this->assertSqlQueryCount($client, 29);
+    }
 }

api/tests/Api/ActivityProgressLabel/ListActivityProgressLabelTest.php

@@ -76,4 +76,12 @@ public function testListActivityProgressLabelsFilteredByCampIsDeniedForUnrelated
         $this->assertJsonContains(['totalItems' => 0]);
         $this->assertArrayNotHasKey('items', $response->toArray()['_links']);
     }
+
+    public function testSqlQueryCount() {
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/activity_progress_labels');
+
+        $this->assertSqlQueryCount($client, 4);
+    }
 }

api/tests/Api/ActivityProgressLabel/ReadActivityProgressLabelTest.php

@@ -92,4 +92,15 @@ public function testGetSingleActivityProgressLabelIsAllowedForManager() {
             ],
         ]);
     }
+
+    public function testSqlQueryCount() {
+        /** @var ActivityProgressLabel $activityProgressLabel */
+        $activityProgressLabel = static::$fixtures['activityProgressLabel1'];
+
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/activity_progress_labels/'.$activityProgressLabel->getId());
+
+        $this->assertSqlQueryCount($client, 5);
+    }
 }

api/tests/Api/ActivityResponsibles/ListActivityResponsiblesTest.php

@@ -135,4 +135,12 @@ public function testListActivityResponsiblesFilteredByCampPrototypeIsAllowedForU
             ['href' => $this->getIriFor('activityResponsible1campPrototype')],
         ], $response->toArray()['_links']['items']);
     }
+
+    public function testSqlQueryCount() {
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/activity_responsibles');
+
+        $this->assertSqlQueryCount($client, 4);
+    }
 }

api/tests/Api/ActivityResponsibles/ReadActivityResponsibleTest.php

@@ -105,4 +105,15 @@ public function testGetSingleActivityResponsibleFromCampPrototypeIsAllowedForUnr
             ],
         ]);
     }
+
+    public function testSqlQueryCount() {
+        /** @var ActivityResponsible $activityResponsible */
+        $activityResponsible = static::$fixtures['activityResponsible1campPrototype'];
+
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/activity_responsibles/'.$activityResponsible->getId());
+
+        $this->assertSqlQueryCount($client, 6);
+    }
 }

api/tests/Api/CampCollaborations/ListCampCollaborationsTest.php

@@ -108,4 +108,12 @@ public function testListCampCollaborationsFilteredByCampPrototypeIsAllowedForUnr
             ['href' => $this->getIriFor('campCollaboration1campPrototype')],
         ], $response->toArray()['_links']['items']);
     }
+
+    public function testSqlQueryCount() {
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/camp_collaborations');
+
+        $this->assertSqlQueryCount($client, 23);
+    }
 }

api/tests/Api/CampCollaborations/ReadCampCollaborationTest.php

@@ -117,4 +117,15 @@ public function testGetSingleCampCollaborationFromCampPrototypeIsAllowedForUnrel
             ],
         ]);
     }
+
+    public function testSqlQueryCount() {
+        /** @var CampCollaboration $campCollaboration */
+        $campCollaboration = static::$fixtures['campCollaboration1manager'];
+
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/camp_collaborations/'.$campCollaboration->getId());
+
+        $this->assertSqlQueryCount($client, 13);
+    }
 }

api/tests/Api/Camps/ListCampsTest.php

@@ -71,4 +71,12 @@ public function testListCampsDoesNotShowCampToInactiveCollaborator() {
             ['href' => $this->getIriFor('campPrototype')],
         ], $response->toArray()['_links']['items']);
     }
+
+    public function testSqlQueryCount() {
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/camps');
+
+        $this->assertSqlQueryCount($client, 27);
+    }
 }

api/tests/Api/Camps/ReadCampTest.php

@@ -211,4 +211,15 @@ public function testGetSingleCampEmbedsCampCollaborationsAndItsUser() {
             ],
         ]);
     }
+
+    public function testSqlQueryCount() {
+        /** @var Camp $camp */
+        $camp = static::$fixtures['camp1'];
+
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/camps/'.$camp->getId());
+
+        $this->assertSqlQueryCount($client, 26);
+    }
 }

api/tests/Api/Categories/ListCategoriesTest.php

@@ -96,4 +96,12 @@ public function testListCategoriesFilteredByCampPrototypeIsAllowedForUnrelatedUs
             ['href' => $this->getIriFor('category1campPrototype')],
         ], $response->toArray()['_links']['items']);
     }
+
+    public function testSqlQueryCount() {
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/categories');
+
+        $this->assertSqlQueryCount($client, 9);
+    }
 }

api/tests/Api/Categories/ReadCategoryTest.php

@@ -128,4 +128,15 @@ public function testGetSingleCategoryFromCampPrototypeIsAllowedForUnrelatedUser(
             ],
         ]);
     }
+
+    public function testSqlQueryCount() {
+        /** @var Category $category */
+        $category = static::$fixtures['category1'];
+
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/categories/'.$category->getId());
+
+        $this->assertSqlQueryCount($client, 7);
+    }
 }

api/tests/Api/ContentTypes/ListContentTypesTest.php

@@ -38,4 +38,12 @@ public function testListContentTypesIsAllowedForLoggedInUser() {
         ]);
         $this->assertCount(7, $response->toArray()['_links']['items']);
     }
+
+    public function testSqlQueryCount() {
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/content_types');
+
+        $this->assertSqlQueryCount($client, 4);
+    }
 }

api/tests/Api/ContentTypes/ReadContentTypeTest.php

@@ -42,4 +42,15 @@ public function testGetSingleContentTypeIsAllowedForLoggedInUser() {
             ],
         ]);
     }
+
+    public function testSqlQueryCount() {
+        /** @var ContentType $contentType */
+        $contentType = static::$fixtures['contentTypeSafetyConcept'];
+
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/content_types/'.$contentType->getId());
+
+        $this->assertSqlQueryCount($client, 4);
+    }
 }

api/tests/Api/DayResponsibles/ListDayResponsiblesTest.php

@@ -101,4 +101,12 @@ public function testListDayResponsiblesFilteredByDayInCampPrototypeIsAllowedForU
             ['href' => $this->getIriFor('dayResponsible1day1period1campPrototype')],
         ], $response->toArray()['_links']['items']);
     }
+
+    public function testSqlQueryCount() {
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/day_responsibles');
+
+        $this->assertSqlQueryCount($client, 4);
+    }
 }

api/tests/Api/DayResponsibles/ReadDayResponsibleTest.php

@@ -105,4 +105,15 @@ public function testGetSingleDayResponsibleInCampPrototypeIsAllowedForUnrelatedU
             ],
         ]);
     }
+
+    public function testSqlQueryCount() {
+        /** @var DayResponsible $dayResponsible */
+        $dayResponsible = static::$fixtures['dayResponsible1'];
+
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/day_responsibles/'.$dayResponsible->getId());
+
+        $this->assertSqlQueryCount($client, 7);
+    }
 }

api/tests/Api/Days/ListDaysTest.php

@@ -122,4 +122,12 @@ public function testListDaysFilteredByPeriodInCampPrototypeIsAllowedForCollabora
             ['href' => $this->getIriFor('day1period1campPrototype')],
         ], $response->toArray()['_links']['items']);
     }
+
+    public function testSqlQueryCount() {
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/days');
+
+        $this->assertSqlQueryCount($client, 15);
+    }
 }

api/tests/Api/Days/ReadDayTest.php

@@ -165,4 +165,15 @@ public function testDatesFormatProperlyInTimezoneBehindUTC() {
             'end' => '2023-05-02T00:00:00+00:00',
         ]);
     }
+
+    public function testSqlQueryCount() {
+        /** @var Day $day */
+        $day = static::$fixtures['day1period1'];
+
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/days/'.$day->getId());
+
+        $this->assertSqlQueryCount($client, 9);
+    }
 }

api/tests/Api/ECampApiTestCase.php

@@ -16,6 +16,7 @@
 use App\Entity\User;
 use App\Metadata\Resource\OperationHelper;
 use App\Repository\ProfileRepository;
+use Doctrine\Bundle\DoctrineBundle\DataCollector\DoctrineDataCollector;
 use Doctrine\ORM\EntityManagerInterface;
 use Hautelook\AliceBundle\PhpUnit\RefreshDatabaseTrait;
 use Symfony\Component\BrowserKit\Cookie;
@@ -297,4 +298,15 @@ protected function assertJsonSchemaError(ResponseInterface $response, string $pr
         $this->assertEquals($propertyName, $responseArray['violations'][0]['propertyPath']);
         $this->assertStringStartsWith('Provided JSON doesn\'t match required schema', $responseArray['violations'][0]['message']);
     }
+
+    /**
+     * Validates the number of executed SqlQueries.
+     * requieres $client->enableProfiler().
+     */
+    protected function assertSqlQueryCount(Client $client, int $expected) {
+        /** @var DoctrineDataCollector $collector */
+        $collector = $client->getProfile()->getCollector('db');
+
+        $this->assertEquals($expected, $collector->getQueryCount());
+    }
 }

api/tests/Api/MaterialItems/ListMaterialItemsTest.php

@@ -164,4 +164,12 @@ public function testListMaterialItemsFilteredByPeriodInCampPrototypeIsAllowedFor
             ['href' => $this->getIriFor('materialItem1period1campPrototype')],
         ], $response->toArray()['_links']['items']);
     }
+
+    public function testSqlQueryCount() {
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/material_items');
+
+        $this->assertSqlQueryCount($client, 4);
+    }
 }

api/tests/Api/MaterialItems/ReadMaterialItemTest.php

@@ -121,4 +121,15 @@ public function testGetSingleMaterialItemInCampPrototypeIsAllowedForUnrelatedUse
             ],
         ]);
     }
+
+    public function testSqlQueryCount() {
+        /** @var MaterialItem $materialItem */
+        $materialItem = static::$fixtures['materialItem1'];
+
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/material_items/'.$materialItem->getId());
+
+        $this->assertSqlQueryCount($client, 6);
+    }
 }

api/tests/Api/MaterialLists/ListMaterialListsTest.php

@@ -102,4 +102,12 @@ public function testListMaterialListsFilteredByCampPrototypeIsAllowedForUnrelate
             ['href' => $this->getIriFor('materialList1campPrototype')],
         ], $response->toArray()['_links']['items']);
     }
+
+    public function testSqlQueryCount() {
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/material_lists');
+
+        $this->assertSqlQueryCount($client, 4);
+    }
 }

api/tests/Api/MaterialLists/ReadMaterialListTest.php

@@ -109,4 +109,15 @@ public function testGetSingleMaterialListFromCampPrototypeIsAllowedForUnrelatedU
             ],
         ]);
     }
+
+    public function testSqlQueryCount() {
+        /** @var MaterialList $materialList */
+        $materialList = static::$fixtures['materialList1'];
+
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/material_lists/'.$materialList->getId());
+
+        $this->assertSqlQueryCount($client, 5);
+    }
 }

api/tests/Api/Periods/ListPeriodsTest.php

@@ -94,4 +94,12 @@ public function testListPeriodsFilteredByCampPrototypeIsAllowedForUnrelatedUser(
             ['href' => $this->getIriFor('period1campPrototype')],
         ], $response->toArray()['_links']['items']);
     }
+
+    public function testSqlQueryCount() {
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/periods');
+
+        $this->assertSqlQueryCount($client, 4);
+    }
 }

api/tests/Api/Periods/ReadPeriodTest.php

@@ -131,4 +131,15 @@ public function testGetSinglePeriodFromCampPrototypeIsAllowedForUnrelatedUser()
             ],
         ]);
     }
+
+    public function testSqlQueryCount() {
+        /** @var Period $period */
+        $period = static::$fixtures['period1'];
+
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/periods/'.$period->getId());
+
+        $this->assertSqlQueryCount($client, 17);
+    }
 }

api/tests/Api/Profiles/ListProfilesTest.php

@@ -111,4 +111,12 @@ public function testListProfilesFilteredByCampPrototypeIsDeniedForUnrelatedUser(
         $this->assertJsonContains(['totalItems' => 0]);
         $this->assertArrayNotHasKey('items', $response->toArray()['_links']);
     }
+
+    public function testSqlQueryCount() {
+        $client = static::createClientWithCredentials();
+        $client->enableProfiler();
+        $client->request('GET', '/profiles');
+
+        $this->assertSqlQueryCount($client, 4);
+    }
 }