Document AWS Setup #3641
Merged
Document AWS Setup #3641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker compose run --rm aws-setup pulumi login s3://ecampcore-pulumi/ docker compose run --rm aws-setup pulumi new aws-typescript --force Issue: ecamp#3478
Issue: ecamp#3478
BacLuc
force-pushed
the
aws-document-setup
branch
from
c04f1b6
to
a5f4e98
Compare
|
Moved everything under a new docs folder. |
There was a problem hiding this comment.
Normally, I would prefer such documentation in the wiki, where the rest of our documentation lives. Since you have so much code here, I see how it is easier to keep it in the repo. However, I'd prefer not to introduce a docs folder in the repository, because this will lead to confusion about where to put documentation in the future. I'd rather have another top-level directory aws-setup or something similar, or in a completely separate repository as you also proposed.
|
@carlobeltrame and @usu decided: we move it in .ops |
pmattmann
approved these changes
Sep 30, 2023
We want to keep documentation in the wiki. A docs folder would attract users to put documentation there. Now we have a .ops folder (with a . to indicate that it is less important), where we can put operations related code. Issue: ecamp#3478
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For PR #3640, here is the documentation of the setup (Bucket, Users, Policies, Access Keys).
I chose Pulumi over AWS CDK and TerraForm because it supports typescript which is similar to the js we know (unlike TerraForm which uses a go like syntax) and typescript is first class citizen (unlike AWS CDK) and it supports multiple cloud providers (unlike AWS CDK).
The question here is: