sentry: add sourcemaps to frontend and print #3713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
BacLuc
force-pushed
the
sentry-sourcemaps
branch
from
7494478
to
299ee04
Compare
BacLuc
force-pushed
the
sentry-sourcemaps
branch
from
299ee04
to
35bce76
Compare
BacLuc
force-pushed
the
sentry-sourcemaps
branch
from
35bce76
to
3b6f48f
Compare
BacLuc
force-pushed
the
sentry-sourcemaps
branch
from
add6b7a
to
9282fbd
Compare
|
This is also i change which would improve the DX when debugging errors from sentry @carlobeltrame and @usu |
Add .cache/npm/sentry-cli to cache. Add it with a .gitkeep file that the permissions are set correctly. Move the .gitkeep instruction from e2e up to the top level .gitignore. It may be that you need to delete your node_modules folders for frontend and print after this commit.
BacLuc
force-pushed
the
sentry-sourcemaps
branch
from
9282fbd
to
9fb9ac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sentry does not officially support node 20 yet.we waited long enough, now sentry supports node 20.In the frontend the sourcemap is helpful: https://ecamp.sentry.io/issues/4396356370/?project=5602507&query=is%3Aunresolved&referrer=issue-stream&stream_index=0
In print i did not achieve yet a useful change in the reporting.
Also tested with the github action, was a little quirky with the build args:
https://github.com/ecamp/ecamp3/actions/runs/5911152402/job/16033412367?pr=3729
In this PR the sourcemaps don't work, because the deploy action uses pull_request_target,
which uses the yaml of the actions on devel.