Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentry: add sourcemaps to frontend and print #3713

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

BacLuc
Copy link
Contributor

@BacLuc BacLuc commented Aug 15, 2023

Sentry does not officially support node 20 yet. we waited long enough, now sentry supports node 20.

In the frontend the sourcemap is helpful: https://ecamp.sentry.io/issues/4396356370/?project=5602507&query=is%3Aunresolved&referrer=issue-stream&stream_index=0

In print i did not achieve yet a useful change in the reporting.

Also tested with the github action, was a little quirky with the build args:
https://github.com/ecamp/ecamp3/actions/runs/5911152402/job/16033412367?pr=3729

In this PR the sourcemaps don't work, because the deploy action uses pull_request_target,
which uses the yaml of the actions on devel.

@BacLuc BacLuc added the deploy! Creates a feature branch deployment for this PR label Aug 15, 2023
@BacLuc BacLuc temporarily deployed to feature-branch August 15, 2023 10:27 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Aug 15, 2023

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@BacLuc BacLuc temporarily deployed to feature-branch August 15, 2023 11:16 — with GitHub Actions Inactive
.github/workflows/reusable-build-and-push.yml Outdated Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
@BacLuc BacLuc temporarily deployed to feature-branch August 19, 2023 10:09 — with GitHub Actions Inactive
@BacLuc BacLuc temporarily deployed to feature-branch August 19, 2023 10:18 — with GitHub Actions Inactive
@BacLuc BacLuc temporarily deployed to feature-branch August 19, 2023 10:31 — with GitHub Actions Inactive
@BacLuc BacLuc temporarily deployed to feature-branch August 19, 2023 10:47 — with GitHub Actions Inactive
@BacLuc BacLuc temporarily deployed to feature-branch August 19, 2023 10:56 — with GitHub Actions Inactive
@BacLuc BacLuc temporarily deployed to feature-branch August 19, 2023 10:57 — with GitHub Actions Inactive
@BacLuc BacLuc linked an issue Aug 19, 2023 that may be closed by this pull request
@BacLuc BacLuc temporarily deployed to feature-branch August 19, 2023 11:08 — with GitHub Actions Inactive
@BacLuc BacLuc temporarily deployed to feature-branch August 19, 2023 11:15 — with GitHub Actions Inactive
@BacLuc BacLuc temporarily deployed to feature-branch August 19, 2023 11:53 — with GitHub Actions Inactive
@BacLuc BacLuc removed the deploy! Creates a feature branch deployment for this PR label Sep 5, 2023
@BacLuc
Copy link
Contributor Author

BacLuc commented Sep 12, 2023

This is also i change which would improve the DX when debugging errors from sentry @carlobeltrame and @usu

Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing!

Add .cache/npm/sentry-cli to cache.
Add it with a .gitkeep file that the permissions are set correctly.
Move the .gitkeep instruction from e2e up to the top level .gitignore.
It may be that you need to delete your node_modules folders for frontend and print after this commit.
Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try

@carlobeltrame carlobeltrame added this pull request to the merge queue Sep 30, 2023
Merged via the queue into ecamp:devel with commit 0fbbe79 Sep 30, 2023
28 checks passed
@BacLuc BacLuc deleted the sentry-sourcemaps branch September 30, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sourcemaps to sentry.io
3 participants