-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sentry: add sourcemaps to frontend and print #3713
Conversation
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
7494478
to
299ee04
Compare
299ee04
to
35bce76
Compare
35bce76
to
3b6f48f
Compare
add6b7a
to
9282fbd
Compare
This is also i change which would improve the DX when debugging errors from sentry @carlobeltrame and @usu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing!
Add .cache/npm/sentry-cli to cache. Add it with a .gitkeep file that the permissions are set correctly. Move the .gitkeep instruction from e2e up to the top level .gitignore. It may be that you need to delete your node_modules folders for frontend and print after this commit.
9282fbd
to
9fb9ac6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try
Sentry does not officially support node 20 yet.we waited long enough, now sentry supports node 20.In the frontend the sourcemap is helpful: https://ecamp.sentry.io/issues/4396356370/?project=5602507&query=is%3Aunresolved&referrer=issue-stream&stream_index=0
In print i did not achieve yet a useful change in the reporting.
Also tested with the github action, was a little quirky with the build args:
https://github.com/ecamp/ecamp3/actions/runs/5911152402/job/16033412367?pr=3729
In this PR the sourcemaps don't work, because the deploy action uses pull_request_target,
which uses the yaml of the actions on devel.