php-cs-fix 3.23.0, phpstan 1.10.29 #3714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usu
reviewed
Aug 15, 2023
There was a problem hiding this comment.
- Did you find out, where the changes were coming from? It seems related to phpdoc_add_missing_param_annotation, but I didn't see any changes on this related to php-cs-fixer 3.23.0
- I would prefer proper PHP type declarations instead of only type annotations (where possible)
- Many of the mixed types could actually be typed properly (string, array, etc.). I would prefer that we fix this already know (at least the easy ones). Once this is merged, it becomes more difficult to differentiate the real "mixed" vs. the lazy "mixed" ones
I agree - let me try |
BacLuc
approved these changes
Aug 15, 2023
usu
approved these changes
Sep 12, 2023
BacLuc
approved these changes
Sep 12, 2023
…tation This reverts the change of CreateColumnLayoutTest of commit 0a3d499, because then we would need to change the interface of all child classes. Psalm, phpstan and php-cs-fixer don't complain, we can do that later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3710