-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite authentication logic with the API store #373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for simpler use of reload in scenarios where we don't know whether or not we already have an entity in the Vuex store: await reload(get().camps())._meta.loaded instead of the following, which is more complicated: await reload(await href(get(), 'camps'))._meta.loaded or the following, which loads the entity twice: await reload(await get().camps()._meta.loaded)._meta.loaded
…d URI from a DELETE call
…I and loaded promises
…ementation, add logout spinner and remove logout view
manuelmeister
approved these changes
Feb 20, 2020
pmattmann
approved these changes
Feb 22, 2020
manuelmeister
approved these changes
Feb 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #355, fixes #318, fixes part of #359, fixes #364
href
that can be used to get the URI of a related entity without fetching it firstloaded
Promises toload
load
Promises (and write tests for them)LoginController
and all its related uses toAuthController
and similarself
links returned from a storeValueProxy (api.get() etc.) are now all absolute URIs (including the host), but in the store we still keep them as normalized, relative URIs, for easier debuggingThe main change is the simpler authentication logic. When before the logic was this:
now the equivalent code is written like this: