print: revert "update js-linter" #3733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usu
approved these changes
Aug 22, 2023
carlobeltrame
approved these changes
Aug 22, 2023
From commit 9b34417. One commit before this still worked, with commit 9b34417 the dev mode is broken. Nuxt 2 clashes with the new prettier, thus we stay at prettier v2. Also add package rules for print/package.json for these 2 packages in renovate.json. Also revert the format changes from 5585942. Else we have the following error for all vue templates when running npm run dev: ecamp3-print | > 1 | [object Promise] ecamp3-print | | ^ ecamp3-print | 2 | export { render, staticRenderFns } ecamp3-print | at parser.next (<anonymous>) ecamp3-print | at normalizeFile.next (<anonymous>) ecamp3-print | at run.next (<anonymous>) ecamp3-print | at transform.next (<anonymous>) ecamp3-print | ecamp3-print | ecamp3-print | [log] [friendly-errors] ecamp3-print | @ ./pages/index.vue?vue&type=template&id=2a183b29& 1:0-290 1:0-290 ecamp3-print | @ ./pages/index.vue ecamp3-print | @ ./.nuxt/router.js ecamp3-print | @ ./.nuxt/index.js ecamp3-print | @ ./.nuxt/client.js ecamp3-print | @ multi ./node_modules/eventsource-polyfill/dist/browserify-eventsource.js (webpack)-hot-middleware/client.js?reload=true&timeout=30000&ansiColors=&overlayStyles=&path=%2F__webpack_hmr%2Fclient&name=client ./.nuxt/client.js
BacLuc
force-pushed
the
fix-print-dev-mode
branch
from
16f65ec
to
ffeaa15
Compare
uups, the renovate.json changes got lost. |
carlobeltrame
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
print: revert "update js-linter"
From commit 9b34417.
One commit before this still worked, with commit 9b34417 the dev mode is broken.
Nuxt 2 clashes with the new prettier, thus we stay at prettier v2.
Also add package rules for print/package.json for these 2 packages in renovate.json.
Also revert the format changes from 5585942.
Else we have the following error for all vue templates when running npm run dev:
ecamp3-print | > 1 | [object Promise]
ecamp3-print | | ^
ecamp3-print | 2 | export { render, staticRenderFns }
ecamp3-print | at parser.next ()
ecamp3-print | at normalizeFile.next ()
ecamp3-print | at run.next ()
ecamp3-print | at transform.next ()
ecamp3-print |
ecamp3-print |
ecamp3-print | [log] [friendly-errors]
ecamp3-print | @ ./pages/index.vue?vue&type=template&id=2a183b29& 1:0-290 1:0-290
ecamp3-print | @ ./pages/index.vue
ecamp3-print | @ ./.nuxt/router.js
ecamp3-print | @ ./.nuxt/index.js
ecamp3-print | @ ./.nuxt/client.js
ecamp3-print | @ multi ./node_modules/eventsource-polyfill/dist/browserify-eventsource.js (webpack)-hot-middleware/client.js?reload=true&timeout=30000&ansiColors=&overlayStyles=&path=%2F__webpack_hmr%2Fclient&name=client ./.nuxt/client.js