api: set report_fields_where_declared:true in doctrine.yaml for doctr… #3749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BacLuc
force-pushed
the
report_fields_where_declared
branch
from
34a9ad9
to
75e12f4
Compare
usu
reviewed
Sep 12, 2023
usu
approved these changes
Sep 12, 2023
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
carlobeltrame
approved these changes
Sep 18, 2023
BacLuc
force-pushed
the
report_fields_where_declared
branch
from
75e12f4
to
d5e1196
Compare
BacLuc
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
…ine/orm 3 And don't overwrite the doctrine definition for the same field again with the same values. Now we define the Constraints on the getter, because api-platform only allows to define constraints on a getter. Move the example on ContentNode::data to the getter, because then this example was used for all children for the data property instead of the example on the getter. Issue: ecamp#3740
BacLuc
force-pushed
the
report_fields_where_declared
branch
from
d5e1196
to
dd6062b
Compare
BacLuc
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
carlobeltrame
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ine/orm 3
And don't overwrite the doctrine definition for the same field again with the same values.
Now we define the Constraints on the getter,
because api-platform only allows to define constraints on a getter. Move the example on ContentNode::data to the getter, because then this example was used for all children for the data property instead of the example on the getter.
Now the comment for the property still overwrites the comments for the getters, but this is ok as the inheritance is an implementation detail, and must not be exposed in the api.Edit by @BacLuc: This was wrongcloses #3740