Fix CD for devel and feature branch #3835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
BacLuc
had a problem deploying
to
feature-branch
GitHub Actions
Failure
💥 Feature branch deployment failed
|
BacLuc
had a problem deploying
to
feature-branch
GitHub Actions
Failure
This was not changed when switching from a scheduled job on devel to a job which is executed when the label is set.
BacLuc
force-pushed
the
fix-ci-for-devel
branch
from
dda28bd
to
e22704c
Compare
| @@ -33,7 +33,7 @@ jobs: | |||
| id: job-url | |||
| with: | |||
| github_token: ${{ secrets.GITHUB_TOKEN }} | |||
| job_name: Upgrade or install deployment (${{ inputs.name }}, ${{ inputs.sha }}, ${{ inputs.pr_number }}) / Deploy to Kubernetes | |||
| job_name: Upgrade or install deployment / Deploy to Kubernetes | |||
There was a problem hiding this comment.
Why is this info not available anymore?
There was a problem hiding this comment.
It is available, but not used anymore for the job_name
manuelmeister
had a problem deploying
to
feature-branch
GitHub Actions
Failure
|
feature branch deployment won't work until this is merged |
manuelmeister
approved these changes
Sep 23, 2023
usu
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was not changed when switching from a scheduled job on devel
to a job which is executed when the label is set.
Before this was not a problem, but with #3803 this is leads to an error.
Successful deployment can be seen here: BacLuc#206
Successful deployment of devel can be seen here: https://github.com/BacLuc/ecamp3/actions/runs/6284222267
(the deployment failed because it conflicted with a deployment of ecamp/ecamp3, but the job id could be retrieved)