Organize admin views #3841
Merged
Organize admin views #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelmeister
added
type: Frontend
UX/UI
deploy!
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
manuelmeister
had a problem deploying
to
feature-branch
GitHub Actions
Failure
manuelmeister
had a problem deploying
to
feature-branch
GitHub Actions
Failure
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
manuelmeister
force-pushed
the
improve/admin
branch
from
8fb4329
to
1501a14
Compare
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
|
@ecamp/core what do you think of this draft? |
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
|
I like it! Minor:
|
pmattmann
approved these changes
Sep 29, 2023
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
BacLuc
approved these changes
Sep 30, 2023
| </v-navigation-drawer> | ||
| </template> | ||
|
|
||
| <script> | ||
| export default { | ||
| name: 'SideBar', | ||
| props: { | ||
| // TODO: Implement title in SideBarProgram as well |
There was a problem hiding this comment.
What is with this todo?
either do it and delete, or create an issue and delete please
manuelmeister
force-pushed
the
improve/admin
branch
from
d4b32e4
to
e0bb34f
Compare
manuelmeister
force-pushed
the
improve/admin
branch
from
e0bb34f
to
47b5a1f
Compare
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
BacLuc
added a commit
to BacLuc/ecamp3
that referenced
this pull request
Oct 21, 2023
Navigate to the list of materiallists in the NavBottombar. Add new view for the list of materiallists to navigate to the details of one materiallist. Rename the views/admin/(,Admin)MaterialLists component to avoid name clash with the new component. Add quick way to differentiate the target routes in the materialListRoute helper for the NavBottombar and NavTopbar. May have been introduced in ecamp#3841. Also add guard if camp is not loaded to materialListRoute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to reorganize the admin views. Also provide better wording for non-managers on the admin/info page. This will make the experience more consistent across devices.
Member view:
Manager view:
In a next PR, I would like to change the api-input prop
disabledtoreadonlyand remove the outlined style of the api-input if it is readonly.FYI: Material lists would be a new view with renaming capabilities. This was not implemented in this draft as it is blocked by #3797.