Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pdf: fix NPE for empty <li> tags in RichText.vue #3868

Merged
merged 1 commit into from
Oct 20, 2023
Merged

pdf: fix NPE for empty <li> tags in RichText.vue #3868

merged 1 commit into from
Oct 20, 2023

Conversation

BacLuc
Copy link
Contributor

@BacLuc BacLuc commented Sep 29, 2023

closes #3759

@BacLuc
Copy link
Contributor Author

BacLuc commented Sep 30, 2023 •
edited
Loading

@carlobeltrame maybe you could help me out quickly.
Why would our custom vue renderer switch between margin and padding between (container, local) and CI?
https://github.com/ecamp/ecamp3/actions/runs/6358702977/job/17271233273?pr=3868

@BacLuc BacLuc force-pushed the pdf-fix-empty-lists branch 2 times, most recently from 80924b4 to 13c1c00 Compare September 30, 2023 14:07
@BacLuc
Copy link
Contributor Author

BacLuc commented Sep 30, 2023

thank you, rebasing worked

carlobeltrame
carlobeltrame requested changes Sep 30, 2023
View reviewed changes
pdf/src/campPrint/RichText.vue Outdated Show resolved Hide resolved
pdf/src/campPrint/RichText.vue Outdated Show resolved Hide resolved
@BacLuc
Copy link
Contributor Author

BacLuc commented Oct 20, 2023

done

@BacLuc BacLuc added this pull request to the merge queue Oct 20, 2023
@carlobeltrame carlobeltrame mentioned this pull request Oct 20, 2023
Open
Merged via the queue into ecamp:devel with commit bedead0 Oct 20, 2023
28 checks passed
@BacLuc BacLuc deleted the pdf-fix-empty-lists branch December 23, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usu usu usu approved these changes

@carlobeltrame carlobeltrame carlobeltrame approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Print Layout #2 breaks with empty bullet list items
3 participants
@BacLuc @usu @carlobeltrame