Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): fix auto-save; improve Controls page #3873

Merged
merged 1 commit into from Oct 1, 2023

Conversation

usu
Copy link
Member

@usu usu commented Sep 30, 2023

fixes #3839

Also improves Controls page by using endpoints corresponding to the individual data types. I started selecting the entities dynamically in the frontend logic, but ended up hardcoding the URIs to ensure the URI ends up with an entity where the general test user actually has access to.

To do:

Copy link
Contributor

@BacLuc BacLuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would also merge this without tests that we have the bugfix on devel.
And i assume that the pickers did not work with autosave before...

@manuelmeister manuelmeister added the deploy! Creates a feature branch deployment for this PR label Sep 30, 2023
@manuelmeister manuelmeister temporarily deployed to feature-branch September 30, 2023 15:15 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Sep 30, 2023

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@usu usu marked this pull request as ready for review October 1, 2023 08:40
@usu usu added this pull request to the merge queue Oct 1, 2023
Merged via the queue into ecamp:devel with commit fc3c93f Oct 1, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autosave is broken
4 participants