Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(print): replace vuetify calendar #3887

Merged
merged 10 commits into from
Oct 21, 2023
Merged

chore(print): replace vuetify calendar #3887

merged 10 commits into from
Oct 21, 2023

Conversation

usu
Copy link
Member

@usu usu commented Sep 30, 2023 •
edited
Loading

  • replaces vuetify calendar in print layout 1
  • uses existing algorithm in print layout 2 to position scheduleEntries
  • no other optimizations, but enables to improve further independently from vuetify

To do:

  • move shared code into common

@usu usu changed the title chore(print): print replace vuetify calendar chore(print): replace vuetify calendar Sep 30, 2023
@usu usu marked this pull request as ready for review September 30, 2023 22:32
@usu usu added the deploy! Creates a feature branch deployment for this PR label Sep 30, 2023
@usu usu temporarily deployed to feature-branch September 30, 2023 22:47 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Sep 30, 2023 •
edited
Loading

⛔ Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@usu usu temporarily deployed to feature-branch September 30, 2023 23:02 — with GitHub Actions Inactive
@usu usu temporarily deployed to feature-branch September 30, 2023 23:24 — with GitHub Actions Inactive
manuelmeister
manuelmeister requested changes Oct 20, 2023
View reviewed changes
Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually it looks good to me.

common/helpers/picasso.js Show resolved Hide resolved
@usu usu temporarily deployed to feature-branch October 20, 2023 22:28 — with GitHub Actions Inactive
manuelmeister
manuelmeister approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@manuelmeister manuelmeister left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only saw multiple visual bugs also present on dev

carlobeltrame
carlobeltrame approved these changes Oct 20, 2023
View reviewed changes
common/helpers/picasso.js Outdated Show resolved Hide resolved
print/package.json
@@ -41,7 +42,6 @@
"@nuxtjs/eslint-config": "12.0.0",
"@nuxtjs/eslint-module": "3.1.0",
"@nuxtjs/stylelint-module": "4.2.1",
"@nuxtjs/vuetify": "1.12.3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@usu usu temporarily deployed to feature-branch October 20, 2023 23:26 — with GitHub Actions Inactive
@BacLuc BacLuc enabled auto-merge October 20, 2023 23:52
@carlobeltrame carlobeltrame temporarily deployed to feature-branch October 21, 2023 00:34 — with GitHub Actions Inactive
@BacLuc BacLuc added this pull request to the merge queue Oct 21, 2023
Merged via the queue into ecamp:devel with commit 407a66a Oct 21, 2023
24 of 28 checks passed
@carlobeltrame carlobeltrame mentioned this pull request Nov 10, 2023
Closed
54 tasks
@carlobeltrame carlobeltrame mentioned this pull request Jan 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BacLuc BacLuc BacLuc approved these changes

@manuelmeister manuelmeister manuelmeister approved these changes

@carlobeltrame carlobeltrame carlobeltrame approved these changes

Assignees
No one assigned
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@usu @BacLuc @manuelmeister @carlobeltrame