Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: don't run CI for branch pushes (already covered by merge_group trigger) #3901

Merged
merged 3 commits into from Oct 21, 2023

Conversation

usu
Copy link
Member

@usu usu commented Oct 1, 2023

Disable CI runs for branch pushes. This avoids double-triggering in the CI (caused by the fact that the merge queue opens a branch in the background for each PR in the merge queue).

The CI continues to be triggered for pull request (pushes on pull request are triggered via the pull_request workflow, and not via the push workflow).

@BacLuc
Copy link
Contributor

BacLuc commented Oct 2, 2023

I find it also useful that the test are run if i push.
That way i don't have to create a pull request to run the CI.
I don't know how we would achieve that.

If the other team members find this better, we can merge this and maybe i have an idea to run it on the pushes in my fork.
in the meantime i will create PR's to my devel.

@manuelmeister
Copy link
Member

We could also just disable CI for those temporary merge queue branches, instead for every branch.

Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manuelmeister manuelmeister added this pull request to the merge queue Oct 21, 2023
Merged via the queue into ecamp:devel with commit 72b58ba Oct 21, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants