Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(print): upgrade to nuxt3 #4003

Merged
merged 40 commits into from Nov 12, 2023
Merged

chore(print): upgrade to nuxt3 #4003

merged 40 commits into from Nov 12, 2023

Conversation

usu
Copy link
Member

@usu usu commented Oct 21, 2023

This PR includes the following major upgrades, which were previously blocked (not listing the ones with no or with only minor impact on the code):

  • Nuxt: from 2 to 3
  • Vue: from 2 to 3
  • vue-i18n: from 8 to 9
  • from webpack to vite
  • from jest to vitest
  • sass: from 1.32.13 to 1.69.4

Results (PDF comparison)

Current dev:
GRGR-dev.pdf

This PR:
GRGR-PR4003.pdf

This PR removes the following dependencies

  • babel: all now works directly on ESM, no extra transpilation necessary
  • express (and also cookie-parser, cors): nuxt3 comes with nitro/h3, no need for express
  • cssesc: was anyway not needed anymore

not included (potential future PRs):

  • some further code simplification would now be possible with nuxt3. Didn't include it in this PR, to avoid making the PR larger than it already is.
  • moving from axios to a more generic fetch API (separate topic + needs adjustments on hal-json-vuex side)

open points

  • release hal-json-vuex v3-alpha
  • sentry reporting
  • check if all npm packages are still needed
  • check if transpilation of vue-icon and colorjs is still needed
  • fix i18n middleware to set language
  • general cleanup (removal of comments, old code, etc.)
  • dayjs doesn't like rollup: locales are not removed by tree-shaking when building the app

Fixes #4072

@usu usu marked this pull request as draft October 21, 2023 17:09
@BacLuc BacLuc mentioned this pull request Oct 23, 2023
1 task
@usu usu added the deploy! Creates a feature branch deployment for this PR label Oct 24, 2023
@usu usu temporarily deployed to feature-branch October 24, 2023 20:12 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Oct 24, 2023

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@carlobeltrame carlobeltrame mentioned this pull request Nov 10, 2023
54 tasks
@usu usu marked this pull request as ready for review November 10, 2023 21:11
@BacLuc BacLuc changed the title chore(print): upgrade to nuxt3 (WIP) chore(print): upgrade to nuxt3 Nov 11, 2023
To not overwrite the component scheduleEntry (<schedule-entry>) with the
data.
That the e2e tests with the production preview also run on port 3003.
Copy link
Contributor

@BacLuc BacLuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX
After the changes from usu#18 we can merge this.

Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@BacLuc BacLuc added this pull request to the merge queue Nov 12, 2023
Merged via the queue into ecamp:devel with commit f46fb47 Nov 12, 2023
28 checks passed
@BacLuc BacLuc mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocks others deploy! Creates a feature branch deployment for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDF content is always english (Layout #1)
4 participants