Implement day responsibles on dashboard #4029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelmeister
added
type: Frontend
UX/UI
deploy!
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
|
I would argue that the we should use 2 different filters for the activity responsible and the day responsible. |
BacLuc
approved these changes
Oct 31, 2023
| @@ -59,7 +107,7 @@ export default { | |||
| components: { CategoryChip, AvatarRow, TextAlignBaseline }, | |||
| mixins: [dateHelperUTCFormatted], | |||
| props: { | |||
| scheduleEntry: { type: Object, required: true }, | |||
| scheduleEntry: { type: Object, default: () => ({ _meta: { loading: true } }) }, | |||
There was a problem hiding this comment.
oh, cool new pattern to avoid the NPE's.
I would highlight this to other team members, that they can use that too
pmattmann
approved these changes
Nov 10, 2023
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the dayResponsibility to the day on the dashboard (non editable). Also keeps schedule entries of days with matching responsibility unfiltered.
Fixes #3885