RequestTransactionListener: also log reason for rollback if rollback throws exception #4035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BacLuc
force-pushed
the
api-do-not-log-there-is-no-active-transaction
branch
2 times, most recently
from
9cdd202
to
3f421c3
Compare
BacLuc
changed the title
…throws exception Else we don't know what caused the rollback in the first place, and cannot find out why there was a rollback even though no rollback is needed. improves ecamp#4034
BacLuc
force-pushed
the
api-do-not-log-there-is-no-active-transaction
branch
from
3f421c3
to
50df69c
Compare
pmattmann
approved these changes
Dec 17, 2023
carlobeltrame
approved these changes
Dec 18, 2023
…is-no-active-transaction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RequestTransactionListener: also log reason for rollback if rollback throws exception
Else we don't know what caused the rollback in the first place,
and cannot find out why there was a rollback even though no rollback is needed.
improves #4034