Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unsupported Intl.ListFormat #4042

Merged
merged 2 commits into from
Nov 5, 2023
Merged

Fix unsupported Intl.ListFormat #4042

merged 2 commits into from
Nov 5, 2023

Conversation

manuelmeister
Copy link
Member

Fixes #4037

carlobeltrame
carlobeltrame approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to remember to do this whereever we use the intl api

@manuelmeister
Copy link
Member Author

manuelmeister commented Nov 5, 2023 •
edited
Loading

@carlobeltrame I would solve this on a per opened sentry issue basis, as I think it is not our goal to make it fully supported in unsupported browsers.

@manuelmeister manuelmeister added this pull request to the merge queue Nov 5, 2023
Merged via the queue into ecamp:devel with commit 87e9403 Nov 5, 2023
28 checks passed
@manuelmeister manuelmeister deleted the bugfix/4037--unsupported-intl branch November 5, 2023 20:34
@sentry-io Sentry.io
Copy link

sentry-io bot commented Nov 6, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: undefined is not a constructor (evaluating 'new Intl.ListFormat(e,{type:this.andFilter?"conjuncti... _sfc_main.computed.labelValue(src/components/da... View Issue

Did you find this useful? React with a 👍 or 👎

carlobeltrame added a commit to carlobeltrame/ecamp3 that referenced this pull request Nov 10, 2023
@carlobeltrame
Add fix for Intl.ListFormat in more places
b63177c 
Continues ecamp#4042
@carlobeltrame carlobeltrame mentioned this pull request Nov 10, 2023
Merged
carlobeltrame added a commit to carlobeltrame/ecamp3 that referenced this pull request Nov 10, 2023
@carlobeltrame
Add fix for Intl.ListFormat in more places
0b3f25d 
Continues ecamp#4042
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BacLuc BacLuc BacLuc approved these changes

@carlobeltrame carlobeltrame carlobeltrame approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@manuelmeister @BacLuc @carlobeltrame