Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty GetCollection entry from HTML serialization without removing hal endpoint #4066

Merged
merged 1 commit into from Nov 25, 2023
Merged

Remove empty GetCollection entry from HTML serialization without removing hal endpoint #4066

merged 1 commit into from Nov 25, 2023

Conversation

manuelmeister
Copy link
Member

before: before with get on invitation (non existing)

after: Bildschirmfoto 2023-11-10 um 21 35 30

@manuelmeister manuelmeister added the deploy! Creates a feature branch deployment for this PR label Nov 10, 2023
@BacLuc
Copy link
Contributor

BacLuc commented Nov 10, 2023

You could also maybe remove the /invitations filter in \App\Tests\Api\SnapshotTests\ResponseSnapshotTest::getCollectionEndpoints

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 10, 2023 •
edited

⛔ Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@manuelmeister manuelmeister added this pull request to the merge queue Nov 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2023
@manuelmeister manuelmeister added this pull request to the merge queue Nov 18, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 18, 2023
@manuelmeister manuelmeister added this pull request to the merge queue Nov 25, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 25, 2023
@manuelmeister manuelmeister added this pull request to the merge queue Nov 25, 2023
Merged via the queue into ecamp:devel with commit 7614a94 Nov 25, 2023
28 checks passed
@manuelmeister manuelmeister deleted the bugfix/openapi-html-docs branch November 25, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usu usu usu approved these changes

@BacLuc BacLuc BacLuc approved these changes

Assignees
No one assigned
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manuelmeister @BacLuc @usu