Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: cancel CI jobs of previous commits on the same branch #4073

Merged
merged 1 commit into from Nov 12, 2023
Merged

CI: cancel CI jobs of previous commits on the same branch #4073

merged 1 commit into from Nov 12, 2023

Conversation

BacLuc
Copy link
Contributor

@BacLuc BacLuc commented Nov 11, 2023 •
edited

grafik

usu
usu approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@usu usu left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Do we want to enable this also for deployment workflows?

EDIT: Ah sorry, just saw it's already in the other PR

@usu
Copy link
Member

usu commented Nov 12, 2023 •
edited

Just an idea if we should use ${{ github.workflow }}-${{ github.sha }}?

At the moment, the CI is still #triggered twice for renovate updates which have a PR: once for the commit on the branch and once for the commit on the PR. With above we could ensure, CI is only run once for a single SHA.

EDIT: Forget it, bad idea. SHA is not the same (one is the regular commit and the other the merge commit). Also it would defeat the original purpose.

@BacLuc BacLuc added this pull request to the merge queue Nov 12, 2023
Merged via the queue into ecamp:devel with commit 0b2aa76 Nov 12, 2023
28 checks passed
@BacLuc BacLuc deleted the ci-serialize-runs branch November 14, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usu usu usu approved these changes

@carlobeltrame carlobeltrame carlobeltrame approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BacLuc @usu @carlobeltrame