print/nuxt.config.js: optimize dayjs deps to avoid console error in dev mode #4107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ev mode Dayjs seems to be distributed as commonjs module. This is no problem in production mode and production preview. But in dev mode, the modules are not transformed by vite and the browser cannot work with the commonjs modules. This fixes the following console error for customParseFormat (and the corresponding erros for the other dayjs plugins): '/print/_nuxt/node_modules/dayjs/plugin/customParseFormat.js?v=6041f242' does not provide an export named 'default'
manuelmeister
approved these changes
Nov 13, 2023
carlobeltrame
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dayjs seems to be distributed as commonjs module.
This is no problem in production mode and production preview. But in dev mode, the modules are not transformed by vite and the browser cannot work with the commonjs modules. This fixes the following console error for customParseFormat (and the corresponding erros for the other dayjs plugins): '/print/_nuxt/node_modules/dayjs/plugin/customParseFormat.js?v=6041f242' does not provide an export named 'default'