Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from coveralls npm dependency to universal coverage reporter #4131

Merged

Conversation

BacLuc
Copy link
Contributor

@BacLuc BacLuc commented Nov 15, 2023

frontend: remove dependency coveralls

We anyway run coveralls via npx in the CI.
Coveralls did not receive updates for some time.
Coveralls.io wants to move to the universal coverage reporter
(https://docs.coveralls.io/integrations#official-integrations).
The npm package has some dependencies which have moderate
security issues:
https://github.com/ecamp/ecamp3/security/dependabot/165
https://github.com/ecamp/ecamp3/security/dependabot/153

continuous-integration.yml: use github action to send js coveralls reports

That we don't use the npm package coveralls anymore.
Coveralls did not receive updates for some time.
Coveralls.io wants to move to the universal coverage reporter
(https://docs.coveralls.io/integrations#official-integrations),
which the github action uses.
The npm package has some dependencies which have moderate
security issues:
https://github.com/ecamp/ecamp3/security/dependabot/165
https://github.com/ecamp/ecamp3/security/dependabot/153

Also add pdf-tests as dependency to coveralls-finished job.
Pin the coveralls action in coveralls-finished.
Do not fail our builds if coveralls is not online right now.

@manuelmeister
Copy link
Member

Cool!

@usu usu enabled auto-merge December 22, 2023 11:11
@usu usu force-pushed the switch-from-coveralls-to-universal-coverage-reporter branch from 54953b5 to 6009098 Compare December 22, 2023 11:18
We anyway run coveralls via npx in the CI.
Coveralls did not receive updates for some time.
Coveralls.io wants to move to the universal coverage reporter
(https://docs.coveralls.io/integrations#official-integrations).
The npm package has some dependencies which have moderate
security issues:
https://github.com/ecamp/ecamp3/security/dependabot/165
https://github.com/ecamp/ecamp3/security/dependabot/153
…ports

That we don't use the npm package coveralls anymore.
Coveralls did not receive updates for some time.
Coveralls.io wants to move to the universal coverage reporter
(https://docs.coveralls.io/integrations#official-integrations),
which the github action uses.
The npm package has some dependencies which have moderate
security issues:
https://github.com/ecamp/ecamp3/security/dependabot/165
https://github.com/ecamp/ecamp3/security/dependabot/153

Also add pdf-tests as dependency to coveralls-finished.
Pin the coveralls action in coveralls-finished.
Do not fail our builds if coveralls is not online right now.
@BacLuc BacLuc force-pushed the switch-from-coveralls-to-universal-coverage-reporter branch from 6009098 to e9b2cc0 Compare December 22, 2023 14:02
@usu usu added this pull request to the merge queue Dec 22, 2023
Merged via the queue into ecamp:devel with commit 66f70b5 Dec 22, 2023
31 checks passed
@BacLuc BacLuc deleted the switch-from-coveralls-to-universal-coverage-reporter branch December 23, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants