chore(deps): update phpunit to 10.4.2 #4188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usu
approved these changes
Dec 22, 2023
| /** | ||
| * @dataProvider usersWhichCanEditCampCollaborations | ||
| */ | ||
| #[DataProvider('usersWhichCanEditCampCollaborations')] |
|
|
||
| <listeners> | ||
| <listener class="Symfony\Bridge\PhpUnit\SymfonyTestsListener" /> |
There was a problem hiding this comment.
Listeners are not supported anymore with phpunit > 10
symfony-phpunit-bridge does not yet have a replacement, but it works now.
https://phpunit.de/announcements/phpunit-10.html
There was a problem hiding this comment.
Ah I see. Doesn't this mean that we loose all the Symfony depreciation warnings then?
There was a problem hiding this comment.
It seems not:
Remaining direct deprecation notices (17)
15x: Since api-platform/core 3.1: The "openapiContext" option is deprecated, use "openapi" instead.
15x in ResponseSnapshotTest::testOpenApiSpecMatchesSnapshot from App\Tests\Api\SnapshotTests
1x: Passing an instance of DateTimeImmutable is deprecated, use Doctrine\DBAL\Types\DateTimeImmutableType::convertToDatabaseValue() instead. (DateTimeType.php:51 called by UTCDateTimeType.php:41, https://github.com/doctrine/dbal/pull/6017, package doctrine/dbal)
1x in UTCDateTimeTypeTest::testDateTimeImmutableConvertsToDatabaseValue from App\Tests\Types\Doctrine
1x: Passing an instance of DateTimeImmutable is deprecated, use Doctrine\DBAL\Types\DateImmutableType::convertToDatabaseValue() instead. (DateType.php:51 called by UTCDateType.php:26, https://github.com/doctrine/dbal/pull/6017, package doctrine/dbal)
1x in UTCDateTypeTest::testDateTimeImmutableConvertsToDatabaseValue from App\Tests\Types\Doctrine
Remaining indirect deprecation notices (9250)
Other deprecation notices (7380)
1477x: Since symfony/framework-bundle 6.4: The "annotations.cached_reader" service is deprecated without replacement.
41x in EndpointQueryCountTest::testNumberOfQueriesDidNotChange from App\Tests\Api\SnapshotTests
8x in CreateColumnLayoutTest::testCreateRejectsParentsWhichDontSupportChildren from App\Tests\Api\ContentNodes\ColumnLayout
8x in UpdateColumnLayoutTest::testPatchRejectsParentsWhichDontSupportChildren from App\Tests\Api\ContentNodes\ColumnLayout
8x in CreateMaterialNodeTest::testCreateRejectsParentsWhichDontSupportChildren from App\Tests\Api\ContentNodes\MaterialNode
8x in UpdateMaterialNodeTest::testPatchRejectsParentsWhichDontSupportChildren from App\Tests\Api\ContentNodes\MaterialNode
...
1477x: Since symfony/framework-bundle 6.4: The "annotations.reader" service is deprecated without replacement.
41x in EndpointQueryCountTest::testNumberOfQueriesDidNotChange from App\Tests\Api\SnapshotTests
8x in CreateColumnLayoutTest::testCreateRejectsParentsWhichDontSupportChildren from App\Tests\Api\ContentNodes\ColumnLayout
8x in UpdateColumnLayoutTest::testPatchRejectsParentsWhichDontSupportChildren from App\Tests\Api\ContentNodes\ColumnLayout
8x in CreateMaterialNodeTest::testCreateRejectsParentsWhichDontSupportChildren from App\Tests\Api\ContentNodes\MaterialNode
8x in UpdateMaterialNodeTest::testPatchRejectsParentsWhichDontSupportChildren from App\Tests\Api\ContentNodes\MaterialNode
...
1477x: Since symfony/framework-bundle 6.4: The "annotations.cache_adapter" service is deprecated without replacement.
41x in EndpointQueryCountTest::testNumberOfQueriesDidNotChange from App\Tests\Api\SnapshotTests
8x in CreateColumnLayoutTest::testCreateRejectsParentsWhichDontSupportChildren from App\Tests\Api\ContentNodes\ColumnLayout
8x in UpdateColumnLayoutTest::testPatchRejectsParentsWhichDontSupportChildren from App\Tests\Api\ContentNodes\ColumnLayout
8x in CreateMaterialNodeTest::testCreateRejectsParentsWhichDontSupportChildren from App\Tests\Api\ContentNodes\MaterialNode
8x in UpdateMaterialNodeTest::testPatchRejectsParentsWhichDontSupportChildren from App\Tests\Api\ContentNodes\MaterialNode
...
1475x: Since symfony/serializer 6.4: Passing a "Doctrine\Common\Annotations\PsrCachedReader" instance as argument 1 to "Symfony\Component\Serializer\Mapping\Loader\AttributeLoader::__construct()" is deprecated, pass null or omit the parameter instead.
41x in EndpointQueryCountTest::testNumberOfQueriesDidNotChange from App\Tests\Api\SnapshotTests
8x in CreateColumnLayoutTest::testCreateRejectsParentsWhichDontSupportChildren from App\Tests\Api\ContentNodes\ColumnLayout
8x in UpdateColumnLayoutTest::testPatchRejectsParentsWhichDontSupportChildren from App\Tests\Api\ContentNodes\ColumnLayout
8x in CreateMaterialNodeTest::testCreateRejectsParentsWhichDontSupportChildren from App\Tests\Api\ContentNodes\MaterialNode
8x in UpdateMaterialNodeTest::testPatchRejectsParentsWhichDontSupportChildren from App\Tests\Api\ContentNodes\MaterialNode
...
1471x: Since symfony/validator 6.4: Method "Symfony\Component\Validator\ValidatorBuilder::setDoctrineAnnotationReader()" is deprecated without replacement.
41x in EndpointQueryCountTest::testNumberOfQueriesDidNotChange from App\Tests\Api\SnapshotTests
8x in CreateColumnLayoutTest::testCreateRejectsParentsWhichDontSupportChildren from App\Tests\Api\ContentNodes\ColumnLayout
8x in UpdateColumnLayoutTest::testPatchRejectsParentsWhichDontSupportChildren from App\Tests\Api\ContentNodes\ColumnLayout
8x in CreateMaterialNodeTest::testCreateRejectsParentsWhichDontSupportChildren from App\Tests\Api\ContentNodes\MaterialNode
8x in UpdateMaterialNodeTest::testPatchRejectsParentsWhichDontSupportChildren from App\Tests\Api\ContentNodes\MaterialNode
...
1x: $typeBuilder argument of TypeConverter implementing "ApiPlatform\GraphQl\Type\TypeBuilderInterface" is deprecated since API Platform 3.1. It has to implement "ApiPlatform\GraphQl\Type\TypeBuilderEnumInterface" instead.
1x in InvitationGraphQLTest::testFindInvitationWhenNotLoggedIn from App\Tests\Api\Invitations
1x: $typeBuilder argument of FieldsBuilder implementing "ApiPlatform\GraphQl\Type\TypeBuilderInterface" is deprecated since API Platform 3.1. It has to implement "ApiPlatform\GraphQl\Type\TypeBuilderEnumInterface" instead.
1x in InvitationGraphQLTest::testFindInvitationWhenNotLoggedIn from App\Tests\Api\Invitations
1x: $fieldsBuilder argument of SchemaBuilder implementing "ApiPlatform\GraphQl\Type\FieldsBuilderInterface" is deprecated since API Platform 3.1. It has to implement "ApiPlatform\GraphQl\Type\FieldsBuilderEnumInterface" instead.
1x in InvitationGraphQLTest::testFindInvitationWhenNotLoggedIn from App\Tests\Api\Invitations
we still have to fix them 😉
1 task
|
I think |
Yes, i assume since you merged devel with the rumantsch changes |
Oops, sorry for that. Didn't notice. Shall I fix it? Or you plan to rebase properly anyway? |
I will rebase properly anyway as soon as i have the approvals |
By running docker compose exec php composer recipes:install symfony/phpunit-bridge --force -v and then reverting the changes not needed for eCampV3 This will allow to update to phpunit 10. (symfony/symfony#49069 (comment))
BacLuc
force-pushed
the
api-update-phpunit-10
branch
from
4b7629e
to
062a145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api: update symfony/phpunit-bridge recipe
By running
docker compose exec php composer recipes:install symfony/phpunit-bridge --force -v
and then reverting the changes not needed for eCampV3
This will allow to update to phpunit 10.
(symfony/symfony#49069 (comment))
chore(deps): update phpunit to 10.4.2