-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activity view: implement day switcher in sidebar #4202
Activity view: implement day switcher in sidebar #4202
Conversation
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
AvatarRow needed to have the bounding rect available, but this in this case it is not available on mount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very cool.
i don't know if we need to add a scroll possibility for small tables yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea - and the sketch is good. It's better than no DaySwitcher.
At the same time, I'm not sure if it could be better
- If a camp has a lot of days, you can't select the last days (see HarryPotter)
- I'm not sure if you're happy with the aesthetics yourself
You need to merge devel again after #4136 |
@pmattmann thanks for the review. I agree with the overflow. However what do you mean with the aesthetics? |
I'll give it a try: |
Create a day switcher in the activity sidebar.
Closes #3963