Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity view: implement day switcher in sidebar #4202

Merged
merged 9 commits into from
Dec 18, 2023

Conversation

manuelmeister
Copy link
Member

@manuelmeister manuelmeister commented Dec 5, 2023

Create a day switcher in the activity sidebar.

Bildschirmfoto 2023-12-18 um 21 42 15 Bildschirmfoto 2023-12-18 um 21 43 33

Closes #3963

@manuelmeister manuelmeister added type: Frontend UX/UI deploy! Creates a feature branch deployment for this PR labels Dec 5, 2023
Copy link

github-actions bot commented Dec 5, 2023

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

AvatarRow needed to have the bounding rect available,
but this in this case it is not available on mount
@manuelmeister manuelmeister changed the title Implement day switcher on activity view Activity view: implement day switcher in sidebar Dec 8, 2023
Copy link
Contributor

@BacLuc BacLuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very cool.
i don't know if we need to add a scroll possibility for small tables yet.

frontend/src/components/activity/DaySwitcher.vue Outdated Show resolved Hide resolved
frontend/src/components/activity/DaySwitcher.vue Outdated Show resolved Hide resolved
frontend/src/components/activity/DaySwitcher.vue Outdated Show resolved Hide resolved
frontend/src/components/activity/DaySwitcher.vue Outdated Show resolved Hide resolved
Copy link
Member

@pmattmann pmattmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea - and the sketch is good. It's better than no DaySwitcher.

At the same time, I'm not sure if it could be better

  • If a camp has a lot of days, you can't select the last days (see HarryPotter)
  • I'm not sure if you're happy with the aesthetics yourself

@BacLuc
Copy link
Contributor

BacLuc commented Dec 17, 2023

You need to merge devel again after #4136

@manuelmeister
Copy link
Member Author

@pmattmann thanks for the review. I agree with the overflow. However what do you mean with the aesthetics?

@pmattmann
Copy link
Member

pmattmann commented Dec 17, 2023

@pmattmann thanks for the review. I agree with the overflow. However what do you mean with the aesthetics?

I'll give it a try:
I think I only found the DaySwitcher because that's what the PR is called. The GUI alone doesn't make it clear that you can click there.
And I think I find the gray circles strange. It took me a moment to understand that it was the tag numbering.

@pmattmann pmattmann added this pull request to the merge queue Dec 18, 2023
Merged via the queue into ecamp:devel with commit f2d0503 Dec 18, 2023
31 checks passed
@manuelmeister manuelmeister deleted the feature/change-day-in-activity branch December 19, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy! Creates a feature branch deployment for this PR type: Frontend UX/UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Activity sidebar: Switch to other days
3 participants