Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve design of layout content nodes in layout mode #4303

Merged

Conversation

manuelmeister
Copy link
Member

@manuelmeister manuelmeister commented Dec 22, 2023

I aligned the design of the layout content nodes in the layout mode to material design.

Implements/improves content node design of #4182

localhost_3000_camps_3c79b99ab424_GRGR_program_activities_12f34c89ce11

@manuelmeister manuelmeister added the deploy! Creates a feature branch deployment for this PR label Dec 22, 2023
Copy link

github-actions bot commented Dec 22, 2023

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

@usu
Copy link
Member

usu commented Dec 23, 2023

Like it. A few comments, some of them not directly related to the improvements from this PR, but it's a good opportunity to throw them in 😄

  • The title of each section (e.g. "Print above main content") is easily read over. I would have emphasized this more (different color? larger text?).

  • For complex layouts, there are a lot of "add buttons". Would it help, if we add a little hint, what/where people are adding stuff? (e.g. "Add (above main content)" or "Add (column 1)"). The second part could also be much smaller to avoid too large buttons.

  • The last "add" button is always a bit confusing, because in paper size (or smaller screens) there are 2 add buttons immediately after each other and I believe it could be non-trivial for users to understand the difference. Would it be an idea, that we restrict the last button to layouts only (column layout or responsive layout) and we call the button "Add layout".

@manuelmeister
Copy link
Member Author

manuelmeister commented Dec 23, 2023

@usu thanks for the review.

I tried to incorporate most of your feedback.

I would not restrict the last (most outer) button to layouts only, as it is a perfect valid use case to just have normal content nodes inside our root columnlayout.

Copy link
Contributor

@BacLuc BacLuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not look through the code and not test it thoroughly.
Looks good on the first glance

@usu
Copy link
Member

usu commented Dec 27, 2023

Also, I noticed a case where the column resize buttons of the column layout disappear when I shrink the window size (happens at the same time as the sidebar collapses). Not sure, though, if this is related to this PR.
Couldn't do a recording (unfortunately my screen recording tool is crashing constantly...). Hence only 2 screenshots below.

Screenshot 2023-12-27 133935

Screenshot 2023-12-27 134022

@manuelmeister
Copy link
Member Author

manuelmeister commented Dec 28, 2023

@usu fixed the hidden resizer button and the disabled inputs.

@manuelmeister
Copy link
Member Author

I think I would merge #4264 first and then test this PR again before we merge it.

@manuelmeister manuelmeister added this pull request to the merge queue Dec 30, 2023
Merged via the queue into ecamp:devel with commit 16565a6 Dec 30, 2023
32 checks passed
@manuelmeister manuelmeister deleted the feature/cleanup-layout-contentnodes branch December 30, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy! Creates a feature branch deployment for this PR type: Frontend UX/UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants