New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve design of layout content nodes in layout mode #4303
Improve design of layout content nodes in layout mode #4303
Conversation
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
Like it. A few comments, some of them not directly related to the improvements from this PR, but it's a good opportunity to throw them in 😄
|
@usu thanks for the review. I tried to incorporate most of your feedback. I would not restrict the last (most outer) button to layouts only, as it is a perfect valid use case to just have normal content nodes inside our root columnlayout. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could not look through the code and not test it thoroughly.
Looks good on the first glance
Also, I noticed a case where the column resize buttons of the column layout disappear when I shrink the window size (happens at the same time as the sidebar collapses). Not sure, though, if this is related to this PR. |
@usu fixed the hidden resizer button and the disabled inputs. |
I think I would merge #4264 first and then test this PR again before we merge it. |
…yout-contentnodes # Conflicts: # frontend/src/components/activity/content/LAThematicArea.vue
I aligned the design of the layout content nodes in the layout mode to material design.
Implements/improves content node design of #4182