Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct grammar of story sentence in de.json #4311

Merged
merged 3 commits into from Jan 12, 2024

Conversation

rafaeldaetwyler
Copy link
Contributor

I changed the grammatical case in the German version of the noStory sentence since it should be in accusative.

Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it was wrong before... It was in passive form before:

"Kein roter Faden [wurde] an diesem Tag gefunden..."

The subject in that case was "Kein roter Faden", and it was correctly in the Nominativ case.

Now with this change, it is changed to an active form:

"[Ich habe] keinen Roten Faden an diesem Tag gefunden..."

To me, the passive sentence sounds a little more natural than the active, since it is unclear who "Ich" would be. But maybe we could re-formulate this sentence completely? How about one of these:

Kein roter Faden
Die Blöcke an diesem Tag enthalten keinen roten Faden.
Kein Block enthält roten Faden.

@manuelmeister
Copy link
Member

In this case I would vote for

Die Blöcke an diesem Tag enthalten keinen roten Faden.

@simfeld
Copy link
Contributor

simfeld commented Dec 27, 2023

+1 for this option from my side because it also informs the user where story content can be added (to a block on that day). Might be obvious for experienced users but maybe not so much for new users with an empty camp.

Die Blöcke an diesem Tag enthalten keinen roten Faden.

@rafaeldaetwyler are you happy to make this change and also adapt the other language files?

@rafaeldaetwyler
Copy link
Contributor Author

This option works for me, too.
I'll do the changes in the next couple of days.

@rafaeldaetwyler
Copy link
Contributor Author

I adapted the sentences in German and English. What is the procedure for translation? Unfortunately, I'm not exactly fluent in the other languages. :(

@carlobeltrame
Copy link
Member

There is in theory a web tool available where translators can see the untranslated and outdated texts. But we are in the process of switching the service we use for this. It's fine for now to only change the string in German and English. Thank you!

Copy link
Contributor

@simfeld simfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@manuelmeister manuelmeister added this pull request to the merge queue Jan 12, 2024
Merged via the queue into ecamp:devel with commit ab48008 Jan 12, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants