vCalendarDragAndDrop.spec.js: make timezone independent #4318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BacLuc
force-pushed
the
make-vCalendarDragAndDrop-tz-independent
branch
from
81e1a64
to
5a50d8d
Compare
usu
approved these changes
Dec 27, 2023
simfeld
approved these changes
Jan 9, 2024
Also use the vCalendar parseDate function to create the CalendarTimestamp object instead of doing it ourselves. Now we don't have to run the frontend tests in a specific timezone anymore, and can later run the tests in 2 timezones to be sure that we handle timezones correctly.
BacLuc
force-pushed
the
make-vCalendarDragAndDrop-tz-independent
branch
from
5a50d8d
to
a8f077e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use the vCalendar parseDate function to create the CalendarTimestamp object instead of doing it ourselves. Now we don't have to run the frontend tests in a specific timezone anymore, and can later run the tests in 2 timezones to be sure that we handle timezones correctly.