chore(print): use css @page landscape instead of content rotation #4347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BacLuc
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
manuelmeister
approved these changes
Dec 29, 2023
Comment on lines
+20
to
+23
| .tw-break-after-page.landscape-page { | ||
| max-width: 1123px; /* page width: A4 landscape width of 297mm at 96dpi */ | ||
| min-height: 794px; /* page height: A4 landscape height of 210mm at 96dpi */ | ||
| } |
There was a problem hiding this comment.
This is for the developer HTML preview which you can see in the iframe on the print page.
BacLuc
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since chrome 118 (included in browserless/chrome:1.61.0-puppeteer-21.4.1) mixing of page orientation is supported.
So we can now use proper css page rules instead of the content rotation hack.
Before (on dev):
GRGR-dev.pdf
After (on PR):
GRGR-PR4347.pdf