Improve alert and popover style #4349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
manuelmeister
commented
Dec 29, 2023
manuelmeister
commented
- Fix activator button not the same size as when popover is open
- Increase text contrast of warning alert
manuelmeister
added
type: Frontend
UX/UI
deploy!
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
manuelmeister
requested review from
BacLuc,
carlobeltrame,
usu and
pmattmann
manuelmeister
changed the title
|
Can you provide an example of what changes - so I don't have to search 🙈 |
|
@pmattmann the alert styling on the login page and the activator button of the delete popover inside the team edit dialog |
pmattmann
reviewed
Jan 3, 2024
frontend/src/scss/global.scss
Outdated
Comment on lines
75
to
84
|
|
||
| .v-alert.warning--text { | ||
| .v-alert__icon { | ||
| color: #d25f00 !important; | ||
| } | ||
| .v-alert__content { | ||
| color: #972e00 !important; | ||
| } | ||
| border-color: #ffe0b2 !important; | ||
| } |
| @@ -12,7 +12,7 @@ | |||
| <template #activator="{ attrs, on }"> | |||
| <slot name="activator" v-bind="{ attrs, on }" /> | |||
| </template> | |||
| <div class="ec-activator" @click="open = false"> | |||
| <div class="ec-activator v-card__actions pa-0" @click="open = false"> | |||
There was a problem hiding this comment.
Before:
After:
The button should now be the same width as the activator button on desktop
pmattmann
approved these changes
Jan 4, 2024
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
carlobeltrame
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.