frontend: report Errors to Sentry in print-nuxt/generatePdfMixin.js #4413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlobeltrame
approved these changes
Jan 9, 2024
We display an error, but the error is not reported to sentry. (I think because we catch the error and don't rethrow). I tested it on staging with nuxt 3, and because there we have no sentry integration yet for nuxt 3, we have no idea how much nuxt 3 fails (except for looking at the logs). So we at least see the errors the frontend can measure.
BacLuc
force-pushed
the
frontend-report-to-sentry-if-nuxt-print-fails
branch
from
620b078
to
e56e475
Compare
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We display an error, but the error is not reported to sentry.
(I think because we catch the error and don't rethrow).
I tested it on staging with nuxt 3, and because there we have no sentry integration yet for nuxt 3,
we have no idea how much nuxt 3 fails (except for looking at the logs).
So we at least see the errors the frontend can measure.