Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: remove vue cli service #4454

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

BacLuc
Copy link
Contributor

@BacLuc BacLuc commented Jan 14, 2024

frontend: remove vue-cli-service

We only used it to lint.
(the i18n-report did not work anymore).
We can do that ourselves.
This also removes 500 dev dependencies and makes it easier to
remove the last 2 security alerts we have on github.
Also the vue cli service does not get updated very often and has
a lot of old and maybe unnecessary dependencies.
It also makes it a little easier to switch to vue3.

Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Omg thank you, finally :celebration:

@manuelmeister manuelmeister self-requested a review January 14, 2024 20:31
We don't have the dependency vue-i18n-extract installed which would provide
the implementation of this command.
We only used it to lint.
(the i18n-report did not work anymore).
We can do that ourselves.
This also removes 500 dev dependencies and makes it easier to
remove the last 2 security alerts we have on github.
Also the vue cli service does not get updated very often and has
a lot of old and maybe unnecessary dependencies.
It also makes it a little easier to switch to vue3.
@BacLuc BacLuc force-pushed the frontend-remove-vue-cli-service branch from 8b8e3f6 to a8d2952 Compare January 16, 2024 16:53
@BacLuc BacLuc enabled auto-merge January 16, 2024 16:54
@BacLuc BacLuc added this pull request to the merge queue Jan 16, 2024
@BacLuc BacLuc removed this pull request from the merge queue due to a manual request Jan 16, 2024
@BacLuc BacLuc added this pull request to the merge queue Jan 16, 2024
Merged via the queue into ecamp:devel with commit 9eab732 Jan 16, 2024
32 checks passed
@BacLuc BacLuc deleted the frontend-remove-vue-cli-service branch January 16, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants