Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): fixes phpstan & psalm errors #4530

Merged
merged 1 commit into from Jan 23, 2024
Merged

fix(api): fixes phpstan & psalm errors #4530

merged 1 commit into from Jan 23, 2024

Conversation

usu
Copy link
Member

@usu usu commented Jan 23, 2024 •
edited

This probably prevents #4526 from fast forwarding

carlobeltrame
carlobeltrame approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@carlobeltrame carlobeltrame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your version is better than mine, because you correctly specified void as the second type for the remove processor.

@carlobeltrame carlobeltrame mentioned this pull request Jan 23, 2024
Closed
@carlobeltrame carlobeltrame added this pull request to the merge queue Jan 23, 2024
Merged via the queue into ecamp:devel with commit 2a34bd8 Jan 23, 2024
32 checks passed
@manuelmeister
Copy link
Member

Thanks! Tried to solve this, but got stuck on the void thing :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BacLuc BacLuc BacLuc approved these changes

@carlobeltrame carlobeltrame carlobeltrame approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@usu @manuelmeister @BacLuc @carlobeltrame