Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow editing instance name in layout mode #4560

Conversation

carlobeltrame
Copy link
Member

Requested by Listo. I have to say I agree with this wish: Layout mode is the correct mode in which I am building up my activity structure, and in which I am adding e.g. a Schlechtwetterprogramm which is a prime example for the usage of layout mode.

In case we decide against this, we currently have a bug: If I activate the instance name edit text field and then switch to layout mode, the text field is still visible and can be saved from within layout mode.

@carlobeltrame carlobeltrame added the deploy! Creates a feature branch deployment for this PR label Jan 27, 2024
Copy link

github-actions bot commented Jan 27, 2024

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm now not sure if we want to allow instancename editing in non layout mode. I think it would be better to just limit this to the layoutmode.

@carlobeltrame carlobeltrame added the Meeting Discuss Am nächsten Core-Meeting besprechen label Jan 28, 2024
@manuelmeister
Copy link
Member

Core Meeting Decision

  • Move button to title
  • Make visible when title is hovered
  • Make tabable / visible on focus
  • Implement for activity title as well
  • Always display instance name edit button in layoutmode

Bildschirmfoto 2024-01-31 um 22 01 06

@manuelmeister manuelmeister removed the Meeting Discuss Am nächsten Core-Meeting besprechen label Jan 31, 2024
Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@pmattmann pmattmann added this pull request to the merge queue Feb 4, 2024
Merged via the queue into ecamp:devel with commit db89dfd Feb 4, 2024
32 checks passed
@carlobeltrame carlobeltrame deleted the allow-editing-instance-name-in-layout-mode branch February 4, 2024 18:08
This was referenced Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants