Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule entry number cleanup #4600

Merged

Commits on Feb 1, 2024

  1. Configuration menu
    Copy the full SHA
    6b2aa69 View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary sorting

    We don't need to sort because all schedule entries of the period are
    fetched when printing is started, and the schedule entries of a period
    are ordered correctly when fetching from the API. This might become
    relevant again far in the future if we introduce more offline
    functionality.
    
    For now, the sorting was incorrect anyways, because it assumed that the
    scheduleEntryNumber was unique per day, which it isn't (there can be
    multiple numbering schemes leading to multiple of the same
    scheduleEntryNumbers on the same day).
    carlobeltrame committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    8ef77ad View commit details
    Browse the repository at this point in the history
  3. Cleanup

    carlobeltrame committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    05a2af5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fb85a49 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2024

  1. Update snapshot which was capturing wrong sorting before

    This snapshot was flawed because of the wrong sorting before. There are
    some schedule entries with numberingScheme 'A' in the store data, and
    these were previously incorrectly sorted:
    dayNumber scheduleEntryNumber number startTime
    1         1                   1.1    08:00
    1         2                   1.2    09:00
    1         1                   1.A    10:00
    
    The last one was previously sorted before the second one, which is
    incorrect.
    carlobeltrame committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    8afd571 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. Configuration menu
    Copy the full SHA
    1f11424 View commit details
    Browse the repository at this point in the history