Add help & news on login screen and main nav #4618
Conversation
manuelmeister
added
type: Frontend
UX/UI
deploy!
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
manuelmeister
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
| <SidebarListItem | ||
| :title="$tc('global.navigation.help')" | ||
| icon="mdi-help-circle-outline" | ||
| :href="helpLink" | ||
| target="_blank" | ||
| /> | ||
| <SidebarListItem | ||
| :title="$tc('global.navigation.news')" | ||
| icon="mdi-news" | ||
| :href="newsLink" | ||
| target="_blank" | ||
| /> |
There was a problem hiding this comment.
Do we really want these 2 links before the camp specific buttons?
now you have to scroll down on a small device to print the camp.
There was a problem hiding this comment.
I don't mind. I think it would be strange to split the global options
There was a problem hiding this comment.
The termsOfServiceLinkTemplate has the same problem, and @manuelmeister made it consistent.
I opened another issue to fix this: #4777
There was a problem hiding this comment.
I would also prefer (and intuitively look for) these points to be at the very bottom of the menu. I see the point about splitting the related options, but I don't think "my camps" is very much related to help and news. Also, help and news are two links which will probably only be used very rarely (especially since help is just the FAQ right now), while "my camps" is used relatively often. That alone justifies moving the help and news links to the bottom for me.
|
It looks cool. |
|
@BacLuc can you do the deployment specific integration please? |
manuelmeister
requested review from
simfeld and
carlobeltrame
and removed request for
carlobeltrame
|
@carlobeltrame can you have a look at this? |
| @@ -87,6 +87,8 @@ jobs: | |||
| --set caddy.image.repository='docker.io/${{ vars.DOCKER_HUB_USERNAME }}/ecamp3-api-caddy' \ | |||
| --set postgresql.dbBackupRestoreImage.repository='docker.io/${{ vars.DOCKER_HUB_USERNAME }}/ecamp3-db-backup-restore' \ | |||
| --set termsOfServiceLinkTemplate='https://ecamp3.ch/{lang}/tos' \ | |||
| --set newsLink='https://ecamp3.ch/blog' \ | |||
| --set helpLink='https://ecamp3.ch/faq' \ | |||
There was a problem hiding this comment.
If the FAQ page is now a help page, I would expect one more question in the FAQ: "My question is not answered here, where can I ask my question?" which links to the contact form.
There was a problem hiding this comment.
Done that: https://www.ecamp3.ch/de/faq/
| <SidebarListItem | ||
| :title="$tc('global.navigation.help')" | ||
| icon="mdi-help-circle-outline" | ||
| :href="helpLink" | ||
| target="_blank" | ||
| /> | ||
| <SidebarListItem | ||
| :title="$tc('global.navigation.news')" | ||
| icon="mdi-news" | ||
| :href="newsLink" | ||
| target="_blank" | ||
| /> |
There was a problem hiding this comment.
I would also prefer (and intuitively look for) these points to be at the very bottom of the menu. I see the point about splitting the related options, but I don't think "my camps" is very much related to help and news. Also, help and news are two links which will probably only be used very rarely (especially since help is just the FAQ right now), while "my camps" is used relatively often. That alone justifies moving the help and news links to the bottom for me.
manuelmeister
had a problem deploying
to
feature-branch
GitHub Actions
Failure
Currently news links to our blog and help to the FAQ page. Maybe this reduces the feature requests for "Meine Aufgaben".