Correctly check inclusion in array #4753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes selecting portrait mode for picasso Refs ecamp#4751 (comment)
Merged
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
BacLuc
approved these changes
Mar 9, 2024
manuelmeister
approved these changes
Mar 10, 2024
manuelmeister
approved these changes
Mar 10, 2024
We don't yet have tests for the config repairing, because this logic is bound to the print configurator Vue components, and isn't as easy to test (I think?) as just importing a JS function and running it in isolation. The tests I did write in #4559 were about the localStorage persistence and Vuex integration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes selecting portrait mode for picasso
Refs #4751 (comment)