-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Prevent wrong dirty reset #4761
Bugfix: Prevent wrong dirty reset #4761
Conversation
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect fix, thank you!
I think this also fixes #4404, is that possible? I wasn't able to reproduce it anymore, even with extremely throttled network connection
@carlobeltrame I don't know, that would be totally awesome of course 😂 |
@usu can you also check this, to make sure I did not make any mistakes or errors of thinking. |
Sorry, didn't manage to test this before it got merged. It seems that on blur, the dirty flag is not properly reset (see screen recording below). Screen.Recording.2024-03-24.at.11.03.44.mov
The 2nd seems like a bug to me, but the first one is also problematic. I labeled #2578 with "Meeting discuss" we we can have a look at it during next meeting. |
Initially, we reset the dirty flag before each save request.
My PR defines
dirty
as "local value is not the same as api value", on devel it is currently defined as "time between entering a different value and starting to patch to api".Some api fields have a
InputFilter/Trim
in the backend, which means that the api value returned will never contain spaces around the value. If the user leaves the input, thelocalValue
should be reset to theapiValue
, to correctly represent the actual db value, without disrupting the user.Closes #3875