New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix printing in languages other than English #4764
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Else it looks good.
Thank you for the tests
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. VueI18n's native locale fallbacking (which simplifies de-CH-scout to de-CH and de, before falling back to our specified fallback language of en) was not working in client print on deployments. It was a similar problem as #3068, but more subtle because generally translations worked, but not always in the right locale. Fixed in 2ad05d5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good by reading
Fixes #4751 (comment), another regression introduced in #4559 which caused the print configurator to always use
'en'
as the language for the pdf.Also added extensive tests for the print config repairing, since this is already the second bug which would have been caught if I had created these earlier.