Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix printing in languages other than English #4764

Merged
merged 6 commits into from Mar 22, 2024

Conversation

carlobeltrame
Copy link
Member

@carlobeltrame carlobeltrame commented Mar 14, 2024

Fixes #4751 (comment), another regression introduced in #4559 which caused the print configurator to always use 'en' as the language for the pdf.

Also added extensive tests for the print config repairing, since this is already the second bug which would have been caught if I had created these earlier.

@carlobeltrame carlobeltrame changed the title Fix printing in languages other than english Fix printing in languages other than English Mar 14, 2024
Copy link
Contributor

@BacLuc BacLuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Else it looks good.
Thank you for the tests

frontend/src/components/print/repairPrintConfig.js Outdated Show resolved Hide resolved
@usu usu added the deploy! Creates a feature branch deployment for this PR label Mar 17, 2024
Copy link

github-actions bot commented Mar 17, 2024

Feature branch deployment currently inactive.

If the PR is still open, you can add the deploy! label to this PR to trigger a feature branch deployment.

Copy link
Member

@usu usu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the PR deployment, layout #2 prints in English, even if the config contains German (see screenshot). Not sure, if this is related to the comment of @BacLuc or whether this is another issue.

image

@carlobeltrame
Copy link
Member Author

carlobeltrame commented Mar 17, 2024

On the PR deployment, layout #2 prints in English, even if the config contains German (see screenshot). Not sure, if this is related to the comment of @BacLuc or whether this is another issue.
image

Nice catch. VueI18n's native locale fallbacking (which simplifies de-CH-scout to de-CH and de, before falling back to our specified fallback language of en) was not working in client print on deployments. It was a similar problem as #3068, but more subtle because generally translations worked, but not always in the right locale. Fixed in 2ad05d5.

Copy link
Member

@manuelmeister manuelmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good by reading

@carlobeltrame carlobeltrame added this pull request to the merge queue Mar 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 21, 2024
@carlobeltrame carlobeltrame added this pull request to the merge queue Mar 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 21, 2024
@carlobeltrame carlobeltrame added this pull request to the merge queue Mar 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 21, 2024
@BacLuc BacLuc added this pull request to the merge queue Mar 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 21, 2024
@carlobeltrame carlobeltrame added this pull request to the merge queue Mar 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 21, 2024
@carlobeltrame carlobeltrame added this pull request to the merge queue Mar 22, 2024
Merged via the queue into ecamp:devel with commit 3d8f7ea Mar 22, 2024
32 checks passed
@carlobeltrame carlobeltrame deleted the fix-print-language branch March 22, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy! Creates a feature branch deployment for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants