Implement empty numbering style #4811
Conversation
carlobeltrame
force-pushed
the
empty-numbering-scheme
branch
from
9ec4df8
to
b2e967c
Compare
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
⛔ Feature branch deployment currently inactive.If the PR is still open, you can add the |
There was a problem hiding this comment.
Very interesting.
I dislike the empty space, but I don't think that we should move the chip to the top in isolated cases (maybe if all categories have empty numbering styles?)
Besides that, it could be useful to have a schedule entry number deattached from the flow and instead only respect the current activity or category. e.g. 1. Nachtessen
| @@ -8,7 +8,7 @@ | |||
| <CategoryChip dense :category="activity.category()" /> {{ | |||
| $vuetify.breakpoint.smAndUp | |||
| ? `${activity.title}: ${items[0].number}` | |||
| : items[0].number | |||
| : shortDescription(items[0]) | |||
There was a problem hiding this comment.
This needs to be shorter. Maybe just the day and start time?
Also between "day" and the number there should be a non-breaking space.
Maybe we could swap the category chip and number, so the category chip is always on top?
I don't really understand what you mean. Can you elaborate or make a mockup? |
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
Done in dda3ff2, check out whether you like that better. |
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
|
Counter-proposal: The font of the number could also be smaller or in gray
|
|
It would be good if we had this numbering style in our development data |
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
In bcf4a76, I set all meal categories (in all camps except for the snow camp) to the new empty numbering scheme, and in the Harry Potter camp I also added some material items and story context to one such activity. |
For direct comparison, the current implementation looks like this: |
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
carlobeltrame
force-pushed
the
empty-numbering-scheme
branch
from
bcf4a76
to
e3c6800
Compare
carlobeltrame
had a problem deploying
to
feature-branch
GitHub Actions
Failure
carlobeltrame
dismissed
manuelmeister’s stale review
Implemented requested changes as far as they were understandable
carlobeltrame
had a problem deploying
to
feature-branch
GitHub Actions
Failure
carlobeltrame
added
deploy!
carlobeltrame
temporarily deployed
to
feature-branch
GitHub Actions
Inactive
Follow-up from ecamp#4811 This does not change anything in the production database. It's just a desperate attempt to not let the prod seeds and prod camp templates drift apart.
Fixes #4597
I found a more or less rational reason for this feature while setting up a camp myself. By using different numbering schemes for different categories, the activity numbers change less often when moving around some stuff on the picasso. And having roman numerals etc. for meals etc. may be perceived as too noisy.